• 
      

    Prevent empty reviews from being published.

    Review Request #13461 — Created Dec. 26, 2023 and submitted — Latest diff uploaded

    Information

    Review Board
    release-6.x

    Reviewers

    With the change to "Create Review" in the new unified banner, we made it
    much easier to have an empty review get published. It used to be that
    closing the review dialog with an empty review would delete the draft,
    but we now keep it around.

    This change adds a validation step for review publishing to ensure that
    the review is not empty.

    • Attempted to publish an empty review from both the unified banner and
      the review dialog. Saw the expected error message.
    • Ran Python and JS unit tests.

    Commits

    Files