Prevent empty reviews from being published.

Review Request #13461 — Created Dec. 26, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

With the change to "Create Review" in the new unified banner, we made it
much easier to have an empty review get published. It used to be that
closing the review dialog with an empty review would delete the draft,
but we now keep it around.

This change adds a validation step for review publishing to ensure that
the review is not empty.

  • Attempted to publish an empty review from both the unified banner and
    the review dialog. Saw the expected error message.
  • Ran Python and JS unit tests.
Summary ID
Prevent empty reviews from being published.
With the change to "Create Review" in the new unified banner, we made it much easier to have an empty review get published. It used to be that closing the review dialog with an empty review would delete the draft, but we now keep it around. This change adds a validation step for review publishing to ensure that the review is not empty. Testing Done: - Attempted to publish an empty review from both the unified banner and the review dialog. Saw the expected error message. - Ran Python and JS unit tests.
167042eaae2ab85ef40b58df792a04d4f8a6b78d
Description From Last Updated

Let's check the the body, Ship It, and pre-queried lists first, to avoid queries if we don't need them.

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/reviews/models/review.py (Diff revision 1)
     
     
     
     
     
     
     
     

    Let's check the the body, Ship It, and pre-queried lists first, to avoid queries if we don't need them.

  3. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (c4788f2)
Loading...