Summary

Prevent empty reviews from being published.

Review Request #13461 — Created Dec. 26, 2023 and submitted Dec. 29, 2023, 6:57 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change adds a validation step for review publishing to ensure that
the review is not empty.

Testing Done


Attempted to publish an empty review from both the unified banner and

  the review dialog. Saw the expected error message.
Ran Python and JS unit tests.

Commits

Summary	ID
Prevent empty reviews from being published. With the change to "Create Review" in the new unified banner, we made it much easier to have an empty review get published. It used to be that closing the review dialog with an empty review would delete the draft, but we now keep it around. This change adds a validation step for review publishing to ensure that the review is not empty. Testing Done: - Attempted to publish an empty review from both the unified banner and the review dialog. Saw the expected error message. - Ran Python and JS unit tests.	167042eaae2ab85ef40b58df792a04d4f8a6b78d

Summary

Prevent empty reviews from being published.

With the change to "Create Review" in the new unified banner, we made it much easier to have an empty review get published. It used to be that closing the review dialog with an empty review would delete the draft, but we now keep it around. This change adds a validation step for review publishing to ensure that the review is not empty. Testing Done: - Attempted to publish an empty review from both the unified banner and the review dialog. Saw the expected error message. - Ran Python and JS unit tests.

167042eaae2ab85ef40b58df792a04d4f8a6b78d

Issues

Description	From	Last Updated
Let's check the the body, Ship It, and pre-queried lists first, to avoid queries if we don't need them.	chipx86	Dec. 28, 2023, 1:02 p.m.

flake8 passed.

JSHint passed.

reviewboard/reviews/models/review.py (Diff revision 1)

The issue has been resolved. Show all issues

Let's check the the body, Ship It, and pre-queried lists first, to avoid queries if we don't need them.

Commits:

	Summary	ID
	Prevent empty reviews from being published. With the change to "Create Review" in the new unified banner, we made it much easier to have an empty review get published. It used to be that closing the review dialog with an empty review would delete the draft, but we now keep it around. This change adds a validation step for review publishing to ensure that the review is not empty. Testing Done: - Attempted to publish an empty review from both the unified banner and the review dialog. Saw the expected error message. - Ran Python and JS unit tests.	1c59e4d141a9abaf26a771d3f2d73e7268b93b5a
	Prevent empty reviews from being published. With the change to "Create Review" in the new unified banner, we made it much easier to have an empty review get published. It used to be that closing the review dialog with an empty review would delete the draft, but we now keep it around. This change adds a validation step for review publishing to ensure that the review is not empty. Testing Done: - Attempted to publish an empty review from both the unified banner and the review dialog. Saw the expected error message. - Ran Python and JS unit tests.	167042eaae2ab85ef40b58df792a04d4f8a6b78d

Diff:

Revision 2 (+56 -8)

Show changes

	reviewboard/notifications/tests/test_email_sending.py
	reviewboard/reviews/models/review.py
	reviewboard/static/rb/js/reviews/views/reviewDialogView.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (c4788f2)