Adjust order of operations in DMARC test mixin setup.

Review Request #13455 — Created Dec. 13, 2023 and submitted

Information

Djblets
release-4.x

Reviewers

I recently ran into an issue where combining the DmarcDnsTestsMixin with
WebAPITestCase was causing very unusual failure cases, which could be
traced back to the cache. We have several things in our new expected
queries which rely on the cache being populated with certain data, but
the order in which things got initialized meant that the test case would
populate the cache, and then this mixin would clear it. We'd then see
extra queries popping up where we didn't expect them.

I've moved the parent class setUp to happen after we've cleared the
cache.

Ran unit tests everywhere.

Summary ID
Adjust order of operations in DMARC test mixin setup.
I recently ran into an issue where combining the DmarcDnsTestsMixin with WebAPITestCase was causing very unusual failure cases, which could be traced back to the cache. We have several things in our new expected queries which rely on the cache being populated with certain data, but the order in which things got initialized meant that the test case would populate the cache, and then this mixin would clear it. We'd then see extra queries popping up where we didn't expect them. I've moved the parent class `setUp` to happen after we've cleared the cache. Testing Done: Ran unit tests everywhere.
f65a71338fc3b41044d784354008f3b9129b8dfa
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (439273e)
Loading...