Summary

Update all datetime/timezone usage to avoid deprecated functionality.

Review Request #13429 — Created Nov. 22, 2023 and submitted Nov. 28, 2023, 7:28 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

~~13428~~

Reviewers

Groups

djblets

People

Description

Django has deprecated django.utils.timezone.utc in favor of
datetime.timezone.utc. The rest of the django.utils.timezone methods
are still supported. Furthermore, datetime.timezone.utc cannot be
directly imported, and must be accessed through datetime.timezone.

This leaves two possible importable targets named datetime (both
datetime and datetime.datetime) and named timezone
(datetime.timezone and django.utils.timezone), all of which are
relevant.

In an effort to keep things sane and consistent, the codebase now
imports the top-level datetime (accessing everything as a direct
property access of that) and django.utils.timezone as timezone in
all affected modules. We may opt to go this route with all new Django
code going forward.

With this change, all datetime-related warnings in unit tests have been
removed.

Testing Done

All unit tests pass.

Commits

Summary	ID
Update all datetime/timezone usage to avoid deprecated functionality. Django has deprecated `django.utils.timezone.utc` in favor of `datetime.timezone.utc`. The rest of the `django.utils.timezone` methods are still supported. Furthermore, `datetime.timezone.utc` cannot be directly imported, and must be accessed through `datetime.timezone`. This leaves two possible importable targets named `datetime` (both `datetime` and `datetime.datetime`) and named `timezone` (`datetime.timezone` and `django.utils.timezone`), all of which are relevant. In an effort to keep things sane and consistent, the codebase now imports the top-level `datetime` (accessing everything as a direct property access of that) and `django.utils.timezone` as `timezone` in all affected modules. We may opt to go this route with all new Django code going forward. With this change, all datetime-related warnings in unit tests have been removed.	e1093159b55a9e930fa00e5652f560fabc034dbd

Summary

Update all datetime/timezone usage to avoid deprecated functionality.

Django has deprecated `django.utils.timezone.utc` in favor of `datetime.timezone.utc`. The rest of the `django.utils.timezone` methods are still supported. Furthermore, `datetime.timezone.utc` cannot be directly imported, and must be accessed through `datetime.timezone`. This leaves two possible importable targets named `datetime` (both `datetime` and `datetime.datetime`) and named `timezone` (`datetime.timezone` and `django.utils.timezone`), all of which are relevant. In an effort to keep things sane and consistent, the codebase now imports the top-level `datetime` (accessing everything as a direct property access of that) and `django.utils.timezone` as `timezone` in all affected modules. We may opt to go this route with all new Django code going forward. With this change, all datetime-related warnings in unit tests have been removed.

e1093159b55a9e930fa00e5652f560fabc034dbd

Issues

Description	From	Last Updated
Looks like you missed this one, this should be changed to just import datetime and the rest of the code …	maubin	Nov. 27, 2023, 10:32 p.m.

flake8 passed.

JSHint passed.

djblets/util/tests/test_dates.py (Diff revision 1)

The issue has been resolved. Show all issues

Looks like you missed this one, this should be changed to just import datetime and the rest of the code updated appropriately.

Change Summary:

Updated test_dates.py for the single import datetime.

Commits:

	Summary	ID
	Update all datetime/timezone usage to avoid deprecated functionality. Django has deprecated `django.utils.timezone.utc` in favor of `datetime.timezone.utc`. The rest of the `django.utils.timezone` methods are still supported. Furthermore, `datetime.timezone.utc` cannot be directly imported, and must be accessed through `datetime.timezone`. This leaves two possible importable targets named `datetime` (both `datetime` and `datetime.datetime`) and named `timezone` (`datetime.timezone` and `django.utils.timezone`), all of which are relevant. In an effort to keep things sane and consistent, the codebase now imports the top-level `datetime` (accessing everything as a direct property access of that) and `django.utils.timezone` as `timezone` in all affected modules. We may opt to go this route with all new Django code going forward. With this change, all datetime-related warnings in unit tests have been removed.	720afe31512de096f1684b44d3ed7c5e83ab6e8c
	Update all datetime/timezone usage to avoid deprecated functionality. Django has deprecated `django.utils.timezone.utc` in favor of `datetime.timezone.utc`. The rest of the `django.utils.timezone` methods are still supported. Furthermore, `datetime.timezone.utc` cannot be directly imported, and must be accessed through `datetime.timezone`. This leaves two possible importable targets named `datetime` (both `datetime` and `datetime.datetime`) and named `timezone` (`datetime.timezone` and `django.utils.timezone`), all of which are relevant. In an effort to keep things sane and consistent, the codebase now imports the top-level `datetime` (accessing everything as a direct property access of that) and `django.utils.timezone` as `timezone` in all affected modules. We may opt to go this route with all new Django code going forward. With this change, all datetime-related warnings in unit tests have been removed.	e1093159b55a9e930fa00e5652f560fabc034dbd

Diff:

Revision 2 (+104 -90)

Show changes

	djblets/db/tests/test_modification_timestamp_field.py
	djblets/privacy/tests/test_base_consent_requirement.py
	djblets/privacy/tests/test_consent_data.py
	djblets/privacy/tests/test_consent_tracker.py
	djblets/util/dates.py
	djblets/util/tests/test_dates.py
	djblets/webapi/tests/test_fields.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (8e7e27d)