Summary

Switch to using run_process() instead of execute() in rbtools.hooks

Review Request #13426 — Created Nov. 21, 2023 and submitted March 4, 2024, 8:54 a.m.

Information

Owner

maubin

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Blocks

13282

Reviewers

Groups

rbtools

People

Description

Since we're deprecating the rbtools.hooks.common.execute(), this change
switches over to using rbtools.utils.process.run_process() instead in our
rbtools.hooks module.

Testing Done

Ran the git-hook-check-approval hook, saw that it worked correctly.

Commits

Summary	ID
Switch to using run_process() instead of execute() in rbtools.hooks	17b5dc1e79fa07890c8abea53346952d7fdf3c55

Issues

Description	From	Last Updated
A good pattern for these more complex statements (especially when they span lines) is to chain them: branches = ( …	chipx86	Nov. 22, 2023, 12:37 p.m.
Along the lines of my older comment, I think for all run_process() calls, we should use the chain form. This …	chipx86	Jan. 3, 2024, 9:57 p.m.

flake8 passed.

JSHint passed.

rbtools/hooks/git.py (Diff revision 1)

The issue has been resolved. Show all issues

A good pattern for these more complex statements (especially when they span lines) is to chain them:

branches = (
    run_process(git_command)
    .stdout
    .read()
    .replace('*', '')
    .split('\n')
)


This is what the other call sites all use.

Commits:

	Summary	ID
	Switch to using run_process() instead of execute() in rbtools.hooks	8e9b77275248e2f1ab9b335adad3971fdf8c6009
	Switch to using run_process() instead of execute() in rbtools.hooks	a43dd220003a017d91418ae46ead7384c246d8cc

Diff:

Revision 2 (+36 -12)

Show changes

rbtools/hooks/git.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

rbtools/hooks/git.py (Diff revision 2)

The issue has been resolved. Show all issues

Along the lines of my older comment, I think for all run_process() calls, we should use the chain form. This is a bit more readable and easier to augment.

Commits:

	Summary	ID
	Switch to using run_process() instead of execute() in rbtools.hooks	a43dd220003a017d91418ae46ead7384c246d8cc
	Switch to using run_process() instead of execute() in rbtools.hooks	17b5dc1e79fa07890c8abea53346952d7fdf3c55

Diff:

Revision 3 (+80 -12)

Show changes

rbtools/hooks/git.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (3792ad8)