Fix bug with review request becoming a draft when a file attachment's thumbnail or extra data gets updated.

Review Request #13423 — Created Nov. 17, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

Currently, when a file attachment's extra data and/or thumbnail gets updated,
the review request that its attached to becomes a draft. This is not desired
behaviour, because these are rather "behind the scenes" updates which should
not affect the draft state of the file attachment or the review request. This
change rearranges things so that if only the extra data and/or thumbnail of
a file attachment are being updated, it does not fetch/create the review
request draft. If the caption and/or pending deletion status are updated,
this will still fetch/create the review request draft.

  • Triggered this bug using Power Pack's upcoming Office document review
    feature and noticed it was fixed.
  • Ran unit tests.
Summary ID
Fix bug with review request becoming a draft when a file attachment's
thumbnail or extra data gets updated.
0d8f819509ea0d202aa3cc6b14ad8520b9d0680c
chipx86
  1. Ship It!
  2. 
      
maubin
Review request changed
Status:
Completed
Change Summary:
Pushed to release-6.x (4b3fa9f)