Summary

Reduce unwanted queries in the Users and Groups datagrids.

Review Request #13422 — Created Nov. 15, 2023 and submitted Dec. 7, 2023, 1:33 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The Users and Groups datagrids both had extra queries conducted per-row,

some due to columns and some due to URL generation.
The Users datagrid was fetching associated review request counts

per-row. The Groups datagrid was fetching Local Sites (when applicable),

associated review request counts, and associated membership counts.
We now use a combination of column-specific and datagrid-specific

query augmentation to select-related or prefetch-related the queries we

need.
The Users datagrid tests have also been updated to ensure all profiles

are pre-created for the tests. This avoids an INSERT for each missing

profile. That may occur in the real world still, when importing users

who haven't logged in yet, but only the first time the profile is

accessed, so it's not worth optimizing around that.

Testing Done

Unit tests pass.

Tested the datagrids manually, making sure all columns and links still
work.

Commits

Summary	ID
Reduce unwanted queries in the Users and Groups datagrids. The Users and Groups datagrids both had extra queries conducted per-row, some due to columns and some due to URL generation. The Users datagrid was fetching associated review request counts per-row. The Groups datagrid was fetching Local Sites (when applicable), associated review request counts, and associated membership counts. We now use a combination of column-specific and datagrid-specific query augmentation to select-related or prefetch-related the queries we need. The Users datagrid tests have also been updated to ensure all profiles are pre-created for the tests. This avoids an INSERT for each missing profile. That may occur in the real world still, when importing users who haven't logged in yet, but only the first time the profile is accessed, so it's not worth optimizing around that.	a25b7c7373840f9221f3b81dc8733bc279d953e1

Summary

Reduce unwanted queries in the Users and Groups datagrids.

The Users and Groups datagrids both had extra queries conducted per-row, some due to columns and some due to URL generation. The Users datagrid was fetching associated review request counts per-row. The Groups datagrid was fetching Local Sites (when applicable), associated review request counts, and associated membership counts. We now use a combination of column-specific and datagrid-specific query augmentation to select-related or prefetch-related the queries we need. The Users datagrid tests have also been updated to ensure all profiles are pre-created for the tests. This avoids an INSERT for each missing profile. That may occur in the real world still, when importing users who haven't logged in yet, but only the first time the profile is accessed, so it's not worth optimizing around that.

a25b7c7373840f9221f3b81dc8733bc279d953e1

Issues

Description	From	Last Updated
'django.db.models.Prefetch' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 16, 2023, 2:29 p.m.
'django.http.HttpRequest' imported but unused Column: 5 Error code: F401	reviewbot	Nov. 16, 2023, 2:29 p.m.
Wrong version (should be 5.0.7).	maubin	Dec. 2, 2023, 5:43 p.m.
Wrong version (should be 5.0.7).	maubin	Dec. 2, 2023, 5:43 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'django.db.models.Prefetch' imported but unused

Column: 1
Error code: F401
```
reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'django.http.HttpRequest' imported but unused

Column: 5
Error code: F401
```

Change Summary:

Removed unused imports.

Commits:

	Summary	ID
	Reduce unwanted queries in the Users and Groups datagrids. The Users and Groups datagrids both had extra queries conducted per-row, some due to columns and some due to URL generation. The Users datagrid was fetching associated review request counts per-row. The Groups datagrid was fetching Local Sites (when applicable), associated review request counts, and associated membership counts. We now use a combination of column-specific and datagrid-specific query augmentation to select-related or prefetch-related the queries we need. The Users datagrid tests have also been updated to ensure all profiles are pre-created for the tests. This avoids an INSERT for each missing profile. That may occur in the real world still, when importing users who haven't logged in yet, but only the first time the profile is accessed, so it's not worth optimizing around that.	22ebaaff23a56d4f84efb5899c8d83420d571698
	Reduce unwanted queries in the Users and Groups datagrids. The Users and Groups datagrids both had extra queries conducted per-row, some due to columns and some due to URL generation. The Users datagrid was fetching associated review request counts per-row. The Groups datagrid was fetching Local Sites (when applicable), associated review request counts, and associated membership counts. We now use a combination of column-specific and datagrid-specific query augmentation to select-related or prefetch-related the queries we need. The Users datagrid tests have also been updated to ensure all profiles are pre-created for the tests. This avoids an INSERT for each missing profile. That may occur in the real world still, when importing users who haven't logged in yet, but only the first time the profile is accessed, so it's not worth optimizing around that.	a25b7c7373840f9221f3b81dc8733bc279d953e1

Diff:

Revision 2 (+556 -254)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/tests/test_groups_list.py
	reviewboard/datagrids/tests/test_users_list.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/datagrids/grids.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Wrong version (should be 5.0.7).
```
reviewboard/datagrids/grids.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Wrong version (should be 5.0.7).
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (2486b25)