Fix the order in which we apply the datagrid queryset data augmentation.

 






 

 


  Review Request #13421
  —
  Created Nov. 16, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Djblets
 









 
 

  release-3.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
The new support for queryset augmentation for data display purposes

didn't work quite right. It applied to the initial query, but we'd then

end up generating a new query based on the IDs returned from that query.

That new query was augmented the old-fashioned way, but not the new way.


This change fixes that up so that we properly augment the final

data-fetching queryset.

 








  


 
 

  
Unit tests pass.


Tested this with some in-progress datagrid fixes in Review Board.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix the order in which we apply the datagrid queryset data augmentation.
     
The new support for queryset augmentation for data display purposes
didn't work quite right. It applied to the initial query, but we'd then
end up generating a new query based on the IDs returned from that query.
That new query was augmented the old-fashioned way, but not the new way.

This change fixes that up so that we properly augment the final
data-fetching queryset.

    

   
  		
  fd48da44cb7f20633432effbf95df42ac7a78875
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/datagrid/grids.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...