Summary

Fix the order in which we apply the datagrid queryset data augmentation.

Review Request #13421 — Created Nov. 16, 2023 and submitted Nov. 27, 2023, 1:47 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The new support for queryset augmentation for data display purposes
didn't work quite right. It applied to the initial query, but we'd then
end up generating a new query based on the IDs returned from that query.
That new query was augmented the old-fashioned way, but not the new way.

This change fixes that up so that we properly augment the final
data-fetching queryset.

Testing Done

Unit tests pass.

Tested this with some in-progress datagrid fixes in Review Board.

Commits

Summary	ID
Fix the order in which we apply the datagrid queryset data augmentation. The new support for queryset augmentation for data display purposes didn't work quite right. It applied to the initial query, but we'd then end up generating a new query based on the IDs returned from that query. That new query was augmented the old-fashioned way, but not the new way. This change fixes that up so that we properly augment the final data-fetching queryset.	fd48da44cb7f20633432effbf95df42ac7a78875

Summary

Fix the order in which we apply the datagrid queryset data augmentation.

The new support for queryset augmentation for data display purposes didn't work quite right. It applied to the initial query, but we'd then end up generating a new query based on the IDs returned from that query. That new query was augmented the old-fashioned way, but not the new way. This change fixes that up so that we properly augment the final data-fetching queryset.

fd48da44cb7f20633432effbf95df42ac7a78875

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (a035bf0)