• 
      

    Update the user page datagrid tests for new equery helpers.

    Review Request #13419 — Created Nov. 15, 2023 and submitted

    Information

    Review Board
    release-5.0.x

    Reviewers

    The user page datagrid unit tests now utilize the new expected query
    helper functions to build more maintainable sets of query expectations
    that the datagrid's queries can be tested against.

    All tests now go through one of two helpers:

    1. _build_user_review_requests_datagrid_equeries(), which manages the
      review requests part of the user page.

    2. _build_user_reviews_datagrid_equeries(), which manages the reviews
      part of the user page.

    These build all the datagrid query assertions, utilizing these helpers
    and the arguments provided to test both datagrids. It's now much easier
    to determine how the tests differ and to keep them maintainable as work
    on the queries continues.

    Unit tests pass.

    Summary ID
    Update the user page datagrid tests for new equery helpers.
    The user page datagrid unit tests now utilize the new expected query helper functions to build more maintainable sets of query expectations that the datagrid's queries can be tested against. All tests now go through one of two helpers: 1. `_build_user_review_requests_datagrid_equeries()`, which manages the review requests part of the user page. 2. `_build_user_reviews_datagrid_equeries()`, which manages the reviews part of the user page. These build all the datagrid query assertions, utilizing these helpers and the arguments provided to test both datagrids. It's now much easier to determine how the tests differ and to keep them maintainable as work on the queries continues.
    b6b16ae00c8f198947d676c3f530ab0f8a927110
    maubin
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-5.0.x (1297237)