Summary

Track subqueries in Q filter values in catch_queries().

Review Request #13404 — Created Nov. 7, 2023 and submitted Nov. 14, 2023, 11:59 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

~~13402~~

Blocks

13405

Reviewers

Groups

djblets

People

Description

catch_queries() now looks for Q(key=SubQuery) expressions, such as

Q(pk__in=MyModel.objects.all()), and records those expressions as

subqueries. This enables deeper comparison of these subqueries, rather

than the old behavior of comparing the resulting object lists.

Testing Done

Unit tests pass.

Verified that I could capture and compare the subqueries in some
in-progress unit tests.

Commits

Summary	ID
Track subqueries in Q filter values in catch_queries(). `catch_queries()` now looks for `Q(key=SubQuery)` expressions, such as `Q(pk__in=MyModel.objects.all())`, and records those expressions as subqueries. This enables deeper comparison of these subqueries, rather than the old behavior of comparing the resulting object lists.	82bb678fd2b1b6c44e589f35bce68de4a484f6cc

Issues

Description	From	Last Updated
local variable 'objs' is assigned to but never used Column: 13 Error code: F841	reviewbot	Nov. 7, 2023, 2:18 a.m.

flake8 failed.

JSHint passed.

flake8

djblets/db/tests/test_query_catcher.py (Diff revision 1)
The issue has been resolved. Show all issues
```
local variable 'objs' is assigned to but never used

Column: 13
Error code: F841
```

Change Summary:

Fixed an unused variable.

Commits:

	Summary	ID
	Track subqueries in Q filter values in catch_queries(). `catch_queries()` now looks for `Q(key=SubQuery)` expressions, such as `Q(pk__in=MyModel.objects.all())`, and records those expressions as subqueries. This enables deeper comparison of these subqueries, rather than the old behavior of comparing the resulting object lists.	09f8429cbe8458335e7c4f97112b1110d5054bbb
	Track subqueries in Q filter values in catch_queries(). `catch_queries()` now looks for `Q(key=SubQuery)` expressions, such as `Q(pk__in=MyModel.objects.all())`, and records those expressions as subqueries. This enables deeper comparison of these subqueries, rather than the old behavior of comparing the resulting object lists.	82bb678fd2b1b6c44e589f35bce68de4a484f6cc

Diff:

Revision 2 (+190 -28)

Show changes

	djblets/db/query_catcher.py
	djblets/db/query_comparator.py
	djblets/db/tests/test_query_catcher.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.x (2784d13)