• 
      

    Add API test methods for providing expected queries for API handlers.

    Review Request #13393 — Created Nov. 6, 2023 and submitted

    Information

    Review Board
    release-5.0.x

    Reviewers

    This introduces a series of build_basic_<method>_expected_queries()
    methods that take in setup state, expected flags for the test, and
    return the expected queries for the test. This will let us incrementally
    add expected queries to API test suites in order to audit performance
    and behavior.

    All of the HTTP method handlers in the basic HTTP mixins either call the
    appropriate build method or hard-code queries (when they're just going
    through standard API layers and not hitting the resources directly).

    This has already caught a few problems in our API implementations, which
    have been fixed and put up for review already.

    Unit tests pass.

    Summary ID
    Add API test methods for providing expected queries for API handlers.
    This introduces a series of `build_basic_<method>_expected_queries()` methods that take in setup state, expected flags for the test, and return the expected queries for the test. This will let us incrementally add expected queries to API test suites in order to audit performance and behavior. All of the HTTP method handlers in the basic HTTP mixins either call the appropriate build method or hard-code queries (when they're just going through standard API layers and not hitting the resources directly). This has already caught a few problems in our API implementations, which have been fixed and put up for review already.
    4f8d7928423c09b769799958212db836f773f8cd
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-5.0.x (cab7813)