Summary

Fix issues when switching and validating search backends.

Review Request #13389 — Created Oct. 30, 2023 and submitted Nov. 1, 2023, 1:17 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

To address this, we now register a new, empty connection alias. We set
this to the new engine and configuration, and then validate using that.
This gives the backend a stable connection to hold onto.

This makes use of modern Haystack's ability to modify and reload a
registered connection, which is the original purpose of the forwarding
backend. This is the reason we're not just using the forwarding backend
for this purpose. However, the forwarding backend is also more complex,
loading state from the site configuration and handling cache-based
syncing, with fallbacks on errors. We don't need or want all that, so we
just work with what Haystack provides us.

Testing Done

Tested switching between backends, with successful and failed validation
attempts. I no longer had any issues. I also added temporary logging to
Haystack to verify configuration and connection states.

Commits

Summary	ID
Fix issues when switching and validating search backends. When switching to a new search backend, validation could fail due to the search backends attempting to access the "default" connection, which is the forwarding backend, and then failing to find the right engine information. To address this, we now register a new, empty connection alias. We set this to the new engine and configuration, and then validate using that. This gives the backend a stable connection to hold onto. This makes use of modern Haystack's ability to modify and reload a registered connection, which is the original purpose of the forwarding backend. This is the reason we're not just using the forwarding backend for this purpose. However, the forwarding backend is also more complex, loading state from the site configuration and handling cache-based syncing, with fallbacks on errors. We don't need or want all that, so we just work with what Haystack provides us.	1fc9d892b007d4726f3231c9c719da54ca9714bf

Summary

Fix issues when switching and validating search backends.

When switching to a new search backend, validation could fail due to the search backends attempting to access the "default" connection, which is the forwarding backend, and then failing to find the right engine information. To address this, we now register a new, empty connection alias. We set this to the new engine and configuration, and then validate using that. This gives the backend a stable connection to hold onto. This makes use of modern Haystack's ability to modify and reload a registered connection, which is the original purpose of the forwarding backend. This is the reason we're not just using the forwarding backend for this purpose. However, the forwarding backend is also more complex, loading state from the site configuration and handling cache-based syncing, with fallbacks on errors. We don't need or want all that, so we just work with what Haystack provides us.

1fc9d892b007d4726f3231c9c719da54ca9714bf

Issues

Description	From	Last Updated
undefined name 'connections' Column: 9 Error code: F821	reviewbot	Oct. 30, 2023, 2:55 p.m.
undefined name 'connections' Column: 9 Error code: F821	reviewbot	Oct. 30, 2023, 2:55 p.m.
undefined name 'connections' Column: 13 Error code: F821	reviewbot	Oct. 30, 2023, 2:55 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/search/search_backends/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
undefined name 'connections'

Column: 9
Error code: F821
```
reviewboard/search/search_backends/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
undefined name 'connections'

Column: 9
Error code: F821
```
reviewboard/search/search_backends/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
undefined name 'connections'

Column: 13
Error code: F821
```

Change Summary:

Added a missing import I forgot to git add -p.

Commits:

	Summary	ID
	Fix issues when switching and validating search backends. When switching to a new search backend, validation could fail due to the search backends attempting to access the "default" connection, which is the forwarding backend, and then failing to find the right engine information. To address this, we now register a new, empty connection alias. We set this to the new engine and configuration, and then validate using that. This gives the backend a stable connection to hold onto. This makes use of modern Haystack's ability to modify and reload a registered connection, which is the original purpose of the forwarding backend. This is the reason we're not just using the forwarding backend for this purpose. However, the forwarding backend is also more complex, loading state from the site configuration and handling cache-based syncing, with fallbacks on errors. We don't need or want all that, so we just work with what Haystack provides us.	de9b967c413e4141eeaf4454a6367f40c9dc0844
	Fix issues when switching and validating search backends. When switching to a new search backend, validation could fail due to the search backends attempting to access the "default" connection, which is the forwarding backend, and then failing to find the right engine information. To address this, we now register a new, empty connection alias. We set this to the new engine and configuration, and then validate using that. This gives the backend a stable connection to hold onto. This makes use of modern Haystack's ability to modify and reload a registered connection, which is the original purpose of the forwarding backend. This is the reason we're not just using the forwarding backend for this purpose. However, the forwarding backend is also more complex, loading state from the site configuration and handling cache-based syncing, with fallbacks on errors. We don't need or want all that, so we just work with what Haystack provides us.	1fc9d892b007d4726f3231c9c719da54ca9714bf