Discussion: auto-formatting (js/common).
Review Request #13382 — Created Oct. 26, 2023 and discarded — Latest diff uploaded
This is here to facilitate our discussion about potentially adopting
auto-formatting for our codebase. This change usesprettier
to format
thecommon
directory in our JavaScript code, with the following
settings:"prettier": { "quoteProps": "consistent", "singleQuote": true, "tabWidth": 4 }
I admit that there are decisions that
prettier
makes that bother me a
bit more than the ones inblack
for Python code. That said, I don't
see anything that I'd consider a deal-breaker, and I still think it may
be an overall productivity win.
Diff Revision 1 (Latest)
Commits
Files
reviewboard/static/rb/js/common/resources/models/draftResourceModelMixin.ts |
---|
reviewboard/static/rb/js/common/resources/models/draftReviewModel.ts |
---|
reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts |
---|
reviewboard/static/rb/js/common/resources/models/reviewModel.ts |
---|
reviewboard/static/rb/js/common/resources/models/reviewReplyModel.ts |
---|
reviewboard/static/rb/js/common/resources/models/tests/baseResourceModelTests.ts |
---|
reviewboard/static/rb/js/common/resources/models/tests/draftReviewModelTests.ts |
---|
reviewboard/static/rb/js/common/resources/models/tests/fileAttachmentModelTests.ts |
---|
reviewboard/static/rb/js/common/resources/models/tests/reviewModelTests.ts |
---|
reviewboard/static/rb/js/common/resources/models/tests/reviewReplyModelTests.ts |
---|
reviewboard/static/rb/js/common/resources/utils/serializers.ts |
---|
reviewboard/static/rb/js/common/views/pageView.ts |
---|
reviewboard/static/rb/js/common/views/tests/pageViewTests.ts |
---|