• 
      

    Discussion: auto-formatting (js/common).

    Review Request #13382 — Created Oct. 26, 2023 and discarded

    Information

    Review Board
    master

    Reviewers

    This is here to facilitate our discussion about potentially adopting
    auto-formatting for our codebase. This change uses prettier to format
    the common directory in our JavaScript code, with the following
    settings:

     "prettier": {
        "quoteProps": "consistent",
        "singleQuote": true,
        "tabWidth": 4
      }
    

    I admit that there are decisions that prettier makes that bother me a
    bit more than the ones in black for Python code. That said, I don't
    see anything that I'd consider a deal-breaker, and I still think it may
    be an overall productivity win.

    
     
    Summary ID
    Discussion: auto-formatting (js/common).
    This is here to facilitate our discussion about potentially adopting auto-formatting for our codebase. This change uses `prettier` to format the `common` directory in our JavaScript code, with the following settings: ``` "prettier": { "quoteProps": "consistent", "singleQuote": true, "tabWidth": 4 } ``` I admit that there are decisions that `prettier` makes that bother me a bit more than the ones in `black` for Python code. That said, I don't see anything that I'd consider a deal-breaker, and I still think it may be an overall productivity win.
    9704370faecbd5bf4a411a773a11fbd2ed573c96
    david
    Review request changed
    Status:
    Discarded