Discussion: auto-formatting (js/common).
Review Request #13382 — Created Oct. 26, 2023 and discarded — Latest diff uploaded
This is here to facilitate our discussion about potentially adopting
auto-formatting for our codebase. This change usesprettier
to format
thecommon
directory in our JavaScript code, with the following
settings:"prettier": { "quoteProps": "consistent", "singleQuote": true, "tabWidth": 4 }
I admit that there are decisions that
prettier
makes that bother me a
bit more than the ones inblack
for Python code. That said, I don't
see anything that I'd consider a deal-breaker, and I still think it may
be an overall productivity win.
Diff Revision 1 (Latest)
Commits
Files
reviewboard/static/rb/js/common/index.ts |
---|
reviewboard/static/rb/js/common/actions/index.ts |
---|
reviewboard/static/rb/js/common/actions/models/actionModel.ts |
---|
reviewboard/static/rb/js/common/actions/models/menuActionModel.ts |
---|
reviewboard/static/rb/js/common/actions/views/actionView.ts |
---|
reviewboard/static/rb/js/common/actions/views/menuActionView.ts |
---|
reviewboard/static/rb/js/common/collections/baseCollection.ts |
---|
reviewboard/static/rb/js/common/models/commChannelModel.ts |
---|
reviewboard/static/rb/js/common/models/extraDataMixin.ts |
---|
reviewboard/static/rb/js/common/models/extraDataModel.ts |
---|
reviewboard/static/rb/js/common/models/pageModel.ts |
---|
reviewboard/static/rb/js/common/models/userSessionModel.ts |
---|
reviewboard/static/rb/js/common/models/tests/commChannelModelTests.ts |
---|
reviewboard/static/rb/js/common/models/tests/extraDataModelTests.ts |
---|
reviewboard/static/rb/js/common/models/tests/userSessionModelTests.ts |
---|
reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts |
---|
reviewboard/static/rb/js/common/resources/collections/tests/resourceCollectionTests.ts |
---|
reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts |
---|
reviewboard/static/rb/js/common/resources/models/draftFileAttachmentModel.ts |
---|
reviewboard/static/rb/js/common/resources/models/draftResourceChildModelMixin.ts |
---|