Expand the Local Site query checks in the Dashboard tests.

Review Request #13363 — Created Oct. 22, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-5.0.x

Reviewers

This splits most of the unit tests in the Dashboard test suite into a
global site test, a Local Site test, and a global site + Local Sites in
the database test.

This gives us thorough query coverage, which unveils a number of
sub-optimal queries that will need to be addressed in upcoming changes.

The queries are intentionally verbose right now, with no query-building
being shared across tests, and with the query-by-query breakdowns
removed. This is intentional, as upcoming work is expected to heavily
impact these queries.

Unit tests pass.

Changes between revision 2 and 3

orig
1
2
3

Commits

Summary ID Author
Expand the Local Site query checks in the Dashboard tests.
This splits most of the unit tests in the Dashboard test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.
867b26c45b66e6d5754c41b4bfa19439c6fdc334 Christian Hammond
Expand the Local Site query checks in the Dashboard tests.
This splits most of the unit tests in the Dashboard test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.
eb0ecc2680f3d36ae4b3289740a9e7db0d5786b6 Christian Hammond
reviewboard/datagrids/tests/test_dashboard.py
Loading...