Work-In-Progress: Buildbot integration




 


  Review Request #1336
  —
  Created Jan. 1, 2010 and discarded

 















 
  
  
 




 
  

   Information

  

 
 

  

   
   
bradh


  


  

   
   
Review Board


  


  

   
   



  


  

   
   



  


  

   
   



  


 



 
  

   Reviewers

  

 
 

  

   
   
reviewboard


  


  

   
   



  


 











 

  
  


The attached patch (my first attempt with Django or Review Board, and it shows) is a work-in-progress for trying to link ReviewBoard and Buildbot. It doesn't work yet - see below.

It relies on using the Buildbot "try" scheduler (see http://djmitche.github.com/buildbot/docs/0.7.11/#try-_002d_002ddiff). 

I'm having trouble with how to make the form submission do anything. I just have no idea how I'm meant to be connecting things up with the javascript etc. Any suggestions / comments would be appreciated.

The other things that is missing is a way to save the diff to a server-side temporary file before submitting that to the buildbot (with the temporary filename as the --diff= argument.




 




 

  
  


I've tried it, and the admin interface part seems OK. The rest is broken.




 














 

  
  
 


 














  

 








 














 



 

  

   





 BR





   

   

  

 



 















 





 

  

   





 BR





   

   





  

 



 

  


   

   

    
 
bradh


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 











  2. 
 
    
  
  
    
  
 
    
  
   New tab
  
  
    This is the new tab.
    
 
    

   
    
    
    




    
    This is the new tab.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
   Form
  
  
    This is where the names of the builders to use for this particular test run will be entered.
    
 
    

   
    
    
    




    
    This is where the names of the builders to use for this particular test run will be entered.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
   Admin Interface
  
  
    Not actually functional yet.
    
 
    

   
    
    
    




    
    Not actually functional yet.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 










  5. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  

 
















 



 

  

   





 BR





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  











 



  

   
Description:

   
    
     
The attached patch (my first attempt with Django or Review Board, and it shows) is a work-in-progress for trying to link ReviewBoard and Buildbot. It doesn't work yet - see below.
     

     
It relies on using the Buildbot "try" scheduler (see http://djmitche.github.com/buildbot/docs/0.7.11/#try-_002d_002ddiff). 
     

     
I'm having trouble with how to make the form submission do anything. I just have no idea how I'm meant to be connecting things up with the javascript etc. Any suggestions / comments would be appreciated.
   + 

   + 
The other things that is missing is a way to save the diff to a server-side temporary file before submitting that to the buildbot (with the temporary filename as the --diff= argument.

   		
  



 










  

 









     

    

   

  

  

   
   Loading...