Clean up the code for the datagrid views.

Review Request #13354 — Created Oct. 17, 2023 and submitted

Information

Review Board
release-5.0.x

Reviewers

The code for datagrid views was pretty ancient, poorly-documented, and
lacked a lot of best practices and modern standards. While not a blocker
for anything, given that some work is going to be done in this module,
it felt time to clean some of this up.

This change updates the module for type checking, modern documentation
standards, and to remove unnecessary arguments to views and to construct
datagrids and query functions with keyword arguments. This will provide
a good base for some further updates.

Unit tests passed.

Tested all the datagrids manually.

Summary ID
Clean up the code for the datagrid views.
The code for datagrid views was pretty ancient, poorly-documented, and lacked a lot of best practices and modern standards. While not a blocker for anything, given that some work is going to be done in this module, it felt time to clean some of this up. This change updates the module for type checking, modern documentation standards, and to remove unnecessary arguments to views and to construct datagrids and query functions with keyword arguments. This will provide a good base for some further updates.
582b649de5b3e628cbdfce6e0a853a54dc1fd682
Description From Last Updated

Single quotes.

daviddavid
david
  1. 
      
  2. reviewboard/datagrids/views.py (Diff revision 1)
     
     

    Single quotes.

  3. 
      
maubin
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (868b34d)
Loading...