Review Request #13337 — Created Oct. 12, 2023 and submitted
relative imports for the modules they want to test. This caused the
tests to test against a copy of the core classes normally exported to
RBnamespace, which meant:
We weren't testing the actual exposed classes, which could cause
state issues or duplicate initialization.
memory/load time for the page.
We weren't in a position to catch whether we properly exported a
RBwhen converting TypeScript code.
Fortunately, issues #1 and #3 haven't been a problem so far, but it's
too easy for something to go wrong there. We want to be testing the same
code and state that the Review Board pages would be loading themselves.
This change updates all the imports in the unit tests to import from the
Verified that the resulting bundle file only had unit test code in it.
Merged two import blocks.
Checks run (2 succeeded)
Thanks for doing this! More and more I'd been leaning towards this, and I was planning on bringing it up after we shipped.