Add touchscreen support for the revision selector.

Review Request #13313 — Created Oct. 6, 2023 and updated

Information

Review Board
master

Reviewers

The revision selector didn't really work with touchscreens. Though touch
events will generally emit mouse events, they don't really work
correctly for this widget. To make this work smoothly, we need to handle
touch events.

This change adds event handlers for touch events. These work the same
way as the mouse events, with different elements and related events
being managed depending on the initial event. The mouse and touch event
handlers wrap common methods that do all the usual work.

Unit tests pass.

Tested various drag operations using both the mouse and touchscreens
(real on iOS and simulated in Chrome and Firefox).

Summary ID
Add touchscreen support for the revision selector.
The revision selector didn't really work with touchscreens. Though touch events will generally emit mouse events, they don't really work correctly for this widget. To make this work smoothly, we need to handle touch events. This change adds event handlers for touch events. These work the same way as the mouse events, with different elements and related events being managed depending on the initial event. The mouse and touch event handlers wrap common methods that do all the usual work.
b339360a7a400a5ba9bbc3760351d2de3ad9db18
maubin
  1. Ship It!
  2. 
      
david
  1. Let's land this one on master for 7.0 along with the other diff viewer change.

  2. 
      
chipx86
Review request changed

Branch:

-release-6.x
+master
david
  1. Ship It!
  2. 
      
Loading...