Summary

Display the site data directory in get_data_dir's error message.

Review Request #13305 — Created Oct. 4, 2023 and submitted Oct. 12, 2023, 1:18 p.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We don't properly display the site data directory in get_data_dir's
error message. This change fixes that.

Testing Done


Ran into a case where the error is displayed and saw that the site

  data directory was included in the error message.

Commits

Summary	ID
Fix the ImproperlyConfigured error message for get_data_dir.	7a2c0ad633579e46d91a09f50fe12a8367aad26a

Issues

Description	From	Last Updated
This has to be %'d outside of the _(), or it can't be localized. The _() will take the string …	chipx86	Oct. 6, 2023, 9:08 a.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/admin/server.py (Diff revision 1)

The issue has been resolved. Show all issues

This has to be %'d outside of the _(), or it can't be localized. The _() will take the string (which must be static) and look it up, and can then apply any %s in it.

Commits:

	Summary	ID
	Fix the ImproperlyConfigured error message for get_data_dir.	f6737ede3f38455a7caa46a7b79c9b8461cfd982
	Fix the ImproperlyConfigured error message for get_data_dir.	7a2c0ad633579e46d91a09f50fe12a8367aad26a

Diff:

Revision 2 (+2 -2)

Show changes

reviewboard/admin/server.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (de9c9c2)