Summary

Actually force a reload when the CommChannel tells the page to reload.

Review Request #13273 — Created Sept. 12, 2023 and submitted Sept. 16, 2023, 4:59 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The new communication channel implementation allows one tab to tell
others to reload themselves, but I had implemented that by basically
doing window.location = window.location. This was fine for most cases,
but if there was an active anchor in the URL, the page would just scroll
to that anchor. This change fixes it to actually call
window.location.reload().

Testing Done


Verified that reloading worked correctly.
Ran unit tests.

Commits

Summary	ID
Actually force a reload when the CommChannel tells the page to reload. The new communication channel implementation allows one tab to tell others to reload themselves, but I had implemented that by basically doing `window.location = window.location`. This was fine for most cases, but if there was an active anchor in the URL, the page would just scroll to that anchor. This change fixes it to actually call `window.location.reload()`. Testing Done: - Verified that reloading worked correctly. - Ran unit tests.	a420bf74a406ea511e46b5987a7b82881f10fadb

Summary

Actually force a reload when the CommChannel tells the page to reload.

The new communication channel implementation allows one tab to tell others to reload themselves, but I had implemented that by basically doing `window.location = window.location`. This was fine for most cases, but if there was an active anchor in the URL, the page would just scroll to that anchor. This change fixes it to actually call `window.location.reload()`. Testing Done: - Verified that reloading worked correctly. - Ran unit tests.

a420bf74a406ea511e46b5987a7b82881f10fadb

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (2365d95)