Summary

Add configuration for @typescript-eslint/no-unused-vars.

Review Request #13271 — Created Sept. 12, 2023 and submitted Sept. 28, 2023, 12:48 p.m.

Information

Owner

david

Repository

beanbag-eslint-plugin

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

When running on TypeScript files, the basic eslint no-unused-vars plugin

is replaced by a TS version, which didn't have any configuration. This

was causing errors on things like unused function parameters, which we

don't want (we often declare function signatures in parent classes which

are implemented in child classes).
This change adds the necessary configuration for this to work.

Testing Done

Saw that I no longer got errors about unused function parameters when

working with TypeScript files.

Commits

Summary	ID
Add configuration for @typescript-eslint/no-unused-vars. When running on TypeScript files, the basic eslint no-unused-vars plugin is replaced by a TS version, which didn't have any configuration. This was causing errors on things like unused function parameters, which we don't want (we often declare function signatures in parent classes which are implemented in child classes). This change adds the necessary configuration for this to work. Testing Done: Saw that I no longer got errors about unused function parameters when working with TypeScript files.	b46532752d322c59dd4741e9edb58298246edb35

Summary

Add configuration for @typescript-eslint/no-unused-vars.

When running on TypeScript files, the basic eslint no-unused-vars plugin is replaced by a TS version, which didn't have any configuration. This was causing errors on things like unused function parameters, which we don't want (we often declare function signatures in parent classes which are implemented in child classes). This change adds the necessary configuration for this to work. Testing Done: Saw that I no longer got errors about unused function parameters when working with TypeScript files.

b46532752d322c59dd4741e9edb58298246edb35

Issues

Description	From	Last Updated
These should be listed in alphabetical order.	chipx86	Sept. 19, 2023, 1:22 p.m.

flake8 passed.

JSHint passed.

src/index.ts (Diff revision 1)

The issue has been resolved. Show all issues

These should be listed in alphabetical order.

david Sept. 19, 2023, 1:23 p.m.

I'll switch these but I think it's still a good idea to group the JS and typescript versions of the same thing next to each other.

Commits:

	Summary	ID
	Add configuration for @typescript-eslint/no-unused-vars. When running on TypeScript files, the basic eslint no-unused-vars plugin is replaced by a TS version, which didn't have any configuration. This was causing errors on things like unused function parameters, which we don't want (we often declare function signatures in parent classes which are implemented in child classes). This change adds the necessary configuration for this to work. Testing Done: Saw that I no longer got errors about unused function parameters when working with TypeScript files.	2784647e8daea02499ba053a5c0395461b3dbc43
	Add configuration for @typescript-eslint/no-unused-vars. When running on TypeScript files, the basic eslint no-unused-vars plugin is replaced by a TS version, which didn't have any configuration. This was causing errors on things like unused function parameters, which we don't want (we often declare function signatures in parent classes which are implemented in child classes). This change adds the necessary configuration for this to work. Testing Done: Saw that I no longer got errors about unused function parameters when working with TypeScript files.	b46532752d322c59dd4741e9edb58298246edb35

Diff:

Revision 2 (+36 -4)

Show changes

src/index.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (ceef953)