Move the '#' character out of the link on the review request box.

Review Request #13269 — Created Sept. 11, 2023 and submitted

Information

Review Board
release-5.0.x

Reviewers

While this is not completely consistent across browsers, Chrome allows
people to right click on a link and select "copy", which will copy the
text of the link. We had a user report that it was awkward using this
with the ID in the review request box because it would include a '#'
character, making it so that pasting into other systems required manual
editing.

In order to facilitate copying just the review request ID number, this
change moves the '#' out of the link element.

In Chrome, right clicked on the review request ID link and copied it.
Pasted and saw that the clipboard only contained the ID number without
the hash character.

Summary ID
Move the '#' character out of the link on the review request box.
While this is not completely consistent across browsers, Chrome allows people to right click on a link and select "copy", which will copy the text of the link. We had a user report that it was awkward using this with the ID in the review request box because it would include a '#' character, making it so that pasting into other systems required manual editing. In order to facilitate copying just the review request ID number, this change moves the '#' out of the link element. Testing Done: In Chrome, right clicked on the review request ID link and copied it. Pasted and saw that the clipboard only contained the ID number without the hash character.
45059884e077b0aa1eac2d06bf4b4d39b5c390fc
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.0.x (51405b4)