Add modern API error types and update tests for Djblets error types.

 






 

 


  Review Request #13264
  —
  Created Sept. 6, 2023 and submitted 

 




















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  13263
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Djblets 4 is gaining additional support in API error payloads for error

type strings (a more useful equivalent to numeric codes) and other

useful error information.


This change adds types to Review Board's API errors, and documents the

errors in the process. It also updates unit tests to check against the

updated payloads with type information.

 








  


 
 

  
Unit tests pass.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Add modern API error types and update tests for Djblets error types.
      
Djblets 4 is gaining additional support in API error payloads for error
type strings (a more useful equivalent to numeric codes) and other
useful error information.

This change adds types to Review Board's API errors, and documents the
errors in the process. It also updates unit tests to check against the
updated payloads with type information.

     


    		
    fc910daa70558d602a43c8bedd4390cd5320b62e

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
too many blank lines (3) Column: 1 Error code: E303

      		
      
       reviewbotreviewbot
      
      
       
      
     


    
   

  

 







 






  

 



















 




 

  


   

   

    
 
Checks run (1 failed, 1 succeeded)


    
   


  

  

  





 

 flake8
 failed.
 





 

 JSHint
 passed.
 













 
flake8

 


 










  

 





 














 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




chipx86




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-6.x (f84ea92)





 


 










  

 









     

    

   

  

  

   
   Loading...