Summary

Add modern API error types and update tests for Djblets error types.

Review Request #13264 — Created Sept. 6, 2023 and submitted Sept. 8, 2023, 4:07 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

~~13263~~

Reviewers

Groups

reviewboard

People

Description

Djblets 4 is gaining additional support in API error payloads for error
type strings (a more useful equivalent to numeric codes) and other
useful error information.

This change adds types to Review Board's API errors, and documents the
errors in the process. It also updates unit tests to check against the
updated payloads with type information.

Testing Done

Unit tests pass.

Commits

Summary	ID
Add modern API error types and update tests for Djblets error types. Djblets 4 is gaining additional support in API error payloads for error type strings (a more useful equivalent to numeric codes) and other useful error information. This change adds types to Review Board's API errors, and documents the errors in the process. It also updates unit tests to check against the updated payloads with type information.	fc910daa70558d602a43c8bedd4390cd5320b62e

Summary

Add modern API error types and update tests for Djblets error types.

Djblets 4 is gaining additional support in API error payloads for error type strings (a more useful equivalent to numeric codes) and other useful error information. This change adds types to Review Board's API errors, and documents the errors in the process. It also updates unit tests to check against the updated payloads with type information.

fc910daa70558d602a43c8bedd4390cd5320b62e

Issues

Description	From	Last Updated
too many blank lines (3) Column: 1 Error code: E303	reviewbot	Sept. 6, 2023, 7:21 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/errors.py (Diff revision 1)
The issue has been resolved. Show all issues
```
too many blank lines (3)

Column: 1
Error code: E303
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (f84ea92)