Summary

Added type hints and modernize docs for djblets.webapi.errors.

Review Request #13258 — Created Sept. 5, 2023 and submitted Sept. 7, 2023, 3:59 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-4.x

Bugs

Depends On

Blocks

13259

Reviewers

Groups

djblets

People

Description

This updates djblets.webapi.errors to include type hints and modern

documentation. This class is ancient, and was not up to our current

standards.
This is in preparation for upcoming work on error support.
There is one small feature addition in that with_override() and

with_message() will now do the right thing if called on a WebAPIError

subclass. While not a pattern we currently explicitly support, this is

more correct and helps future-proof the class.

Testing Done

Unit tests pass.

Commits

Summary	ID
Added type hints and modernize docs for djblets.webapi.errors. This updates `djblets.webapi.errors` to include type hints and modern documentation. This class is ancient, and was not up to our current standards. This is in preparation for upcoming work on error support.	fbf71485cfe44eee9a55863fa38719b2d2eaccdd

flake8 passed.

JSHint passed.

Change Summary:

Updated to allow the HTTP headers to be a callable.

Commits:

	Summary	ID
	Added type hints and modernize docs for djblets.webapi.errors. This updates `djblets.webapi.errors` to include type hints and modern documentation. This class is ancient, and was not up to our current standards. This is in preparation for upcoming work on error support.	1d5ace0325a640e5506e054ac1b883ae77262f00
	Added type hints and modernize docs for djblets.webapi.errors. This updates `djblets.webapi.errors` to include type hints and modern documentation. This class is ancient, and was not up to our current standards. This is in preparation for upcoming work on error support.	a38e5e421e0f3bbc3d672e23a9f996919b978574

Diff:

Revision 2 (+314 -36)

Show changes

djblets/webapi/errors.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fixed bad import ordering.

Commits:

	Summary	ID
	Added type hints and modernize docs for djblets.webapi.errors. This updates `djblets.webapi.errors` to include type hints and modern documentation. This class is ancient, and was not up to our current standards. This is in preparation for upcoming work on error support.	a38e5e421e0f3bbc3d672e23a9f996919b978574
	Added type hints and modernize docs for djblets.webapi.errors. This updates `djblets.webapi.errors` to include type hints and modern documentation. This class is ancient, and was not up to our current standards. This is in preparation for upcoming work on error support.	fbf71485cfe44eee9a55863fa38719b2d2eaccdd

Diff:

Revision 3 (+312 -36)

Show changes

djblets/webapi/errors.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (a765c20)