Summary

Add a standard exception for unverified SSL certificates.

Review Request #13256 — Created Sept. 5, 2023 and submitted Sept. 8, 2023, 4:07 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This introduces CertificateVerificationError, which represents an

unverified certificate, and VerificationFailureCode, which is an enum

of handled error codes. These will be used product-wide to represent

verification failures, replacing the now-deprecated

reviewboard.scmtools.errors.UnverifiedCertificateError.
The new error class provides default error messages for different error

codes, and allows for some custom formatting containing certificate

information.

Testing Done

Unit tests passed.

Made use of this in in-progress code.

Commits

Summary	ID
Add a standard exception for unverified SSL certificates. This introduces `CertificateVerificationError`, which represents an unverified certificate, and `VerificationFailureCode`, which is an enum of handled error codes. These will be used product-wide to represent verification failures, replacing the now-deprecated `reviewboard.scmtools.errors.UnverifiedCertificateError`. The new error class provides default error messages for different error codes, and allows for some custom formatting containing certificate information.	0819d07c8579b6dcf26a7a51883e0731abe8da45

Summary

Add a standard exception for unverified SSL certificates.

This introduces `CertificateVerificationError`, which represents an unverified certificate, and `VerificationFailureCode`, which is an enum of handled error codes. These will be used product-wide to represent verification failures, replacing the now-deprecated `reviewboard.scmtools.errors.UnverifiedCertificateError`. The new error class provides default error messages for different error codes, and allows for some custom formatting containing certificate information.

0819d07c8579b6dcf26a7a51883e0731abe8da45

Issues

Description	From	Last Updated
f-string is missing placeholders Column: 13 Error code: F541	reviewbot	Sept. 5, 2023, 4:30 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/certs/tests/test_certificate_verification_error.py (Diff revision 1)
The issue has been resolved. Show all issues
```
f-string is missing placeholders

Column: 13
Error code: F541
```

Change Summary:

Removed an unnecessary use of an f-string.

Commits:

	Summary	ID
	Add a standard exception for unverified SSL certificates. This introduces `CertificateVerificationError`, which represents an unverified certificate, and `VerificationFailureCode`, which is an enum of handled error codes. These will be used product-wide to represent verification failures, replacing the now-deprecated `reviewboard.scmtools.errors.UnverifiedCertificateError`. The new error class provides default error messages for different error codes, and allows for some custom formatting containing certificate information.	d65fdf84831b73168d3cfb524014c09395fd98db
	Add a standard exception for unverified SSL certificates. This introduces `CertificateVerificationError`, which represents an unverified certificate, and `VerificationFailureCode`, which is an enum of handled error codes. These will be used product-wide to represent verification failures, replacing the now-deprecated `reviewboard.scmtools.errors.UnverifiedCertificateError`. The new error class provides default error messages for different error codes, and allows for some custom formatting containing certificate information.	0819d07c8579b6dcf26a7a51883e0731abe8da45

Diff:

Revision 2 (+1240 -20)

Show changes

	reviewboard/deprecation.py
	reviewboard/certs/errors.py
	reviewboard/certs/tests/test_certificate_verification_error.py
	reviewboard/scmtools/errors.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (2f71576)