Fix review dialog tips display and make some sizing/a11y tweaks.

Review Request #13245 — Created Aug. 29, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

This change has two pieces:

First, the tips in the review dialog weren't showing correctly because
somewhere along the line I lost the change that actually imports the CSS
for slideshow elements into the common bundle.

Second, the previous, next, and close buttons were all somewhat hard to
hit, and were missing some attributes needed for accessibility.

  • Verified that the tips UI worked correctly.
  • Checked the hit boxes and a11y attributes for the various buttons in
    the box.

Diff Revision 2 (Latest)

orig
1
2

Commits

First Last Summary ID Author
Fix review dialog tips display and make some sizing/a11y tweaks.
This change has two pieces: First, the tips in the review dialog weren't showing correctly because somewhere along the line I lost the change that actually imports the CSS for slideshow elements into the common bundle. Second, the previous, next, and close buttons were all somewhat hard to hit, and were missing some attributes needed for accessibility. Testing Done: - Verified that the tips UI worked correctly. - Checked the hit boxes and a11y attributes for the various buttons in the box.
54d47f6c9dc5538fb4ee1d8c79992e5bf719bc37 David Trowbridge
reviewboard/static/rb/css/bundles/common.less
reviewboard/static/rb/css/pages/reviews.less
reviewboard/static/rb/css/ui/alert.less
reviewboard/static/rb/css/ui/slideshow.less
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts
Loading...