Summary

Allow getting unsorted file attachments from review requests and drafts.

Review Request #13237 — Created Aug. 27, 2023 and submitted Sept. 28, 2023, 11:36 a.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This allows us to avoid some queries whenever we need to grab file attachments
from a review request or a draft but don't care about having them sorted.

Testing Done


Ran unit tests.
Used this in upcoming changes.

Commits

Summary	ID
Allow getting unsorted file attachments from review requests and drafts.	fbe7349c63c36f4bad48a2cf8188464a639e5132

Issues

Description	From	Last Updated
Let's make this a keyword-only argument.	chipx86	Sept. 19, 2023, 10:22 p.m.
Blank line before the with (statements and blocks). Same below.	chipx86	Sept. 19, 2023, 10:23 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/reviews/models/base_review_request_details.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's make this a keyword-only argument.
```
reviewboard/reviews/tests/test_base_review_request_details.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line before the with (statements and blocks).
Same below.
```

Commits:

	Summary	ID
	Allow getting unsorted file attachments from review requests and drafts.	5aa8be049d49c37ae38ebd8b07d6578ba4d3e134
	Allow getting unsorted file attachments from review requests and drafts.	fbe7349c63c36f4bad48a2cf8188464a639e5132

Diff:

Revision 2 (+424 -10)

Show changes

	reviewboard/reviews/models/base_review_request_details.py
	reviewboard/reviews/tests/test_base_review_request_details.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (828fc9f)