Fix overzealous issue summary table reloads.

Review Request #13234 — Created Aug. 23, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

The review request page does some long-running requests to fetch new
updates to various parts, including entries and the issue summary table.
The entries all had an updated timestamp included, and on the client
side we'd check to make sure there actually was an update, but the issue
summary table did not. This change adds a new timestamp to the update
payload for this, and checks that timestamp client-side to prevent us
from doing unnecessary DOM updates.

  • Ran python tests.
  • Ran js-tests.
  • Verified that when just looking at an unchanged page, the issue
    summary table was not being updated in the DOM.
  • Changed some issue state from another tab and saw the issue summary
    table reload correctly.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.

orig
1
2
3
4

Commits

First Last Summary ID Author
Fix overzealous issue summary table reloads.
The review request page does some long-running requests to fetch new updates to various parts, including entries and the issue summary table. The entries all had an updated timestamp included, and on the client side we'd check to make sure there actually was an update, but the issue summary table did not. This change adds a new timestamp to the update payload for this, and checks that timestamp client-side to prevent us from doing unnecessary DOM updates. Testing Done: - Ran python tests. - Ran js-tests. - Verified that when just looking at an unchanged page, the issue summary table was not being updated in the DOM. - Changed some issue state from another tab and saw the issue summary table reload correctly.
524b71ad2c0a6b960503314b3a2d8db75c1fb081 David Trowbridge
reviewboard/reviews/detail.py
reviewboard/reviews/tests/test_review_request_updates_view.py
reviewboard/reviews/views/review_request_updates.py
reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageModel.es6.js
Loading...