Summary

Fix overzealous issue summary table reloads.

Review Request #13234 — Created Aug. 23, 2023 and submitted Aug. 25, 2023, 2:40 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Testing Done


Ran python tests.
Ran js-tests.
Verified that when just looking at an unchanged page, the issue

  summary table was not being updated in the DOM.
Changed some issue state from another tab and saw the issue summary

  table reload correctly.

Commits

Summary	ID
Fix overzealous issue summary table reloads. The review request page does some long-running requests to fetch new updates to various parts, including entries and the issue summary table. The entries all had an updated timestamp included, and on the client side we'd check to make sure there actually was an update, but the issue summary table did not. This change adds a new timestamp to the update payload for this, and checks that timestamp client-side to prevent us from doing unnecessary DOM updates. Testing Done: - Ran python tests. - Ran js-tests. - Verified that when just looking at an unchanged page, the issue summary table was not being updated in the DOM. - Changed some issue state from another tab and saw the issue summary table reload correctly.	4c32cd534d203edafec44d6b82b0d7283785861d

Summary

Fix overzealous issue summary table reloads.

The review request page does some long-running requests to fetch new updates to various parts, including entries and the issue summary table. The entries all had an updated timestamp included, and on the client side we'd check to make sure there actually was an update, but the issue summary table did not. This change adds a new timestamp to the update payload for this, and checks that timestamp client-side to prevent us from doing unnecessary DOM updates. Testing Done: - Ran python tests. - Ran js-tests. - Verified that when just looking at an unchanged page, the issue summary table was not being updated in the DOM. - Changed some issue state from another tab and saw the issue summary table reload correctly.

4c32cd534d203edafec44d6b82b0d7283785861d

Issues

Description	From	Last Updated
Missing docs here.	chipx86	Aug. 25, 2023, 2:19 p.m.
Can we type this? I know typing this whole class is a huge amount of work, but we can start …	chipx86	Aug. 24, 2023, 8:50 a.m.
This could probably be: self.latest_issue_timestamp = max( comment.timestamp for comment in self.all_comments )	chipx86	Aug. 24, 2023, 8:50 a.m.

flake8 passed.

JSHint passed.

reviewboard/reviews/detail.py (Diff revision 1)

The issue has been resolved. Show all issues

Can we type this? I know typing this whole class is a huge amount of work, but we can start here.

reviewboard/reviews/detail.py (Diff revision 1)

The issue has been resolved. Show all issues

This could probably be:

self.latest_issue_timestamp = max(
    comment.timestamp
    for comment in self.all_comments
)

Commits:

	Summary	ID
	Fix overzealous issue summary table reloads. The review request page does some long-running requests to fetch new updates to various parts, including entries and the issue summary table. The entries all had an updated timestamp included, and on the client side we'd check to make sure there actually was an update, but the issue summary table did not. This change adds a new timestamp to the update payload for this, and checks that timestamp client-side to prevent us from doing unnecessary DOM updates. Testing Done: - Ran python tests. - Ran js-tests. - Verified that when just looking at an unchanged page, the issue summary table was not being updated in the DOM. - Changed some issue state from another tab and saw the issue summary table reload correctly.	c4ac43b047fa3d2d4843ef452bee74a894c23084
	Fix overzealous issue summary table reloads. The review request page does some long-running requests to fetch new updates to various parts, including entries and the issue summary table. The entries all had an updated timestamp included, and on the client side we'd check to make sure there actually was an update, but the issue summary table did not. This change adds a new timestamp to the update payload for this, and checks that timestamp client-side to prevent us from doing unnecessary DOM updates. Testing Done: - Ran python tests. - Ran js-tests. - Verified that when just looking at an unchanged page, the issue summary table was not being updated in the DOM. - Changed some issue state from another tab and saw the issue summary table reload correctly.	524b71ad2c0a6b960503314b3a2d8db75c1fb081

Diff:

Revision 2 (+84 -4)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/tests/test_review_request_updates_view.py
	reviewboard/reviews/views/review_request_updates.py
	reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageModel.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/reviews/detail.py (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
Missing docs here.
```

Commits:

	Summary	ID
	Fix overzealous issue summary table reloads. The review request page does some long-running requests to fetch new updates to various parts, including entries and the issue summary table. The entries all had an updated timestamp included, and on the client side we'd check to make sure there actually was an update, but the issue summary table did not. This change adds a new timestamp to the update payload for this, and checks that timestamp client-side to prevent us from doing unnecessary DOM updates. Testing Done: - Ran python tests. - Ran js-tests. - Verified that when just looking at an unchanged page, the issue summary table was not being updated in the DOM. - Changed some issue state from another tab and saw the issue summary table reload correctly.	524b71ad2c0a6b960503314b3a2d8db75c1fb081
	Fix overzealous issue summary table reloads. The review request page does some long-running requests to fetch new updates to various parts, including entries and the issue summary table. The entries all had an updated timestamp included, and on the client side we'd check to make sure there actually was an update, but the issue summary table did not. This change adds a new timestamp to the update payload for this, and checks that timestamp client-side to prevent us from doing unnecessary DOM updates. Testing Done: - Ran python tests. - Ran js-tests. - Verified that when just looking at an unchanged page, the issue summary table was not being updated in the DOM. - Changed some issue state from another tab and saw the issue summary table reload correctly.	32db39844380271423800cdd51d515bbb64d495d

Diff:

Revision 3 (+86 -4)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/tests/test_review_request_updates_view.py
	reviewboard/reviews/views/review_request_updates.py
	reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageModel.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Add "Version Added"

Commits:

	Summary	ID
	Fix overzealous issue summary table reloads. The review request page does some long-running requests to fetch new updates to various parts, including entries and the issue summary table. The entries all had an updated timestamp included, and on the client side we'd check to make sure there actually was an update, but the issue summary table did not. This change adds a new timestamp to the update payload for this, and checks that timestamp client-side to prevent us from doing unnecessary DOM updates. Testing Done: - Ran python tests. - Ran js-tests. - Verified that when just looking at an unchanged page, the issue summary table was not being updated in the DOM. - Changed some issue state from another tab and saw the issue summary table reload correctly.	32db39844380271423800cdd51d515bbb64d495d
	Fix overzealous issue summary table reloads. The review request page does some long-running requests to fetch new updates to various parts, including entries and the issue summary table. The entries all had an updated timestamp included, and on the client side we'd check to make sure there actually was an update, but the issue summary table did not. This change adds a new timestamp to the update payload for this, and checks that timestamp client-side to prevent us from doing unnecessary DOM updates. Testing Done: - Ran python tests. - Ran js-tests. - Verified that when just looking at an unchanged page, the issue summary table was not being updated in the DOM. - Changed some issue state from another tab and saw the issue summary table reload correctly.	4c32cd534d203edafec44d6b82b0d7283785861d

Diff:

Revision 4 (+92 -4)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/tests/test_review_request_updates_view.py
	reviewboard/reviews/views/review_request_updates.py
	reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageModel.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (bfbe6e2)