Use the modern spinner throughout the UI.

Review Request #13232 — Created Aug. 23, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

In Review Board 5, we introduced a new SVG-based spinner, which lacked
the wobble of the Font Awesome glyph-based spinner. All of Djblets and
parts of Review Board were updated to use it, but we still had plenty of
code using the old spinner.

This change converts the rest of the codebase to use the new one. It's
basically a drop-in replacement, though it did require some small
adjustments in some parts of the UI to better fit the size or visuals.
In particular, file attachment thumbnails now use margins to position
it, and, given the spinner size, reduce the opacity to make it less
strong.

Tested each spinner in the UI, before and after the change, to make
sure that sizes were still correct.

Summary ID
Use the modern spinner throughout the UI.
In Review Board 5, we introduced a new SVG-based spinner, which lacked the wobble of the Font Awesome glyph-based spinner. All of Djblets and parts of Review Board were updated to use it, but we still had plenty of code using the old spinner. This change converts the rest of the codebase to use the new one. It's basically a drop-in replacement, though it did require some small adjustments in some parts of the UI to better fit the size or visuals. In particular, file attachment thumbnails now use margins to position it, and, given the spinner size, reduce the opacity to make it less strong.
bfc680615960443dbe366ce022a17a41de28d759

maubin
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-6.x (1c45fc6)