chipx86 got a fish trophy!
Fix attribute default pollution in some models.
Review Request #13231 — Created Aug. 23, 2023 and submitted — Latest diff uploaded
We had a few models that were polluting defaults in other models, due to
_.defaults()
parameters appearing in the wrong order.This change fixes three cases that were found, and finishes an audit of
all uses in the Review Board codebase.
Unit tests pass.
Been running with this change for several days and haven't encountered
any issues.