Fish Trophy

chipx86 got a fish trophy!

Fix attribute default pollution in some models.

Review Request #13231 — Created Aug. 23, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

We had a few models that were polluting defaults in other models, due to
_.defaults() parameters appearing in the wrong order.

This change fixes three cases that were found, and finishes an audit of
all uses in the Review Board codebase.

Unit tests pass.

Been running with this change for several days and haven't encountered
any issues.

Summary ID
Fix attribute default pollution in some models.
We had a few models that were polluting defaults in other models, due to `_.defaults()` parameters appearing in the wrong order. This change fixes three cases that were found, and finishes an audit of all uses in the Review Board codebase.
bcf69530ff1a87f316e269d71aeed5e6afe714db
maubin
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (59db38f)
Loading...