chipx86 got a fish trophy!

Summary

Fix attribute default pollution in some models.

Review Request #13231 — Created Aug. 23, 2023 and submitted Aug. 28, 2023, 1:33 p.m.

Owner

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Groups

People

Description

We had a few models that were polluting defaults in other models, due to
_.defaults() parameters appearing in the wrong order.

This change fixes three cases that were found, and finishes an audit of
all uses in the Review Board codebase.

Testing Done

Unit tests pass.

Been running with this change for several days and haven't encountered
any issues.

Commits

Summary	ID
Fix attribute default pollution in some models. We had a few models that were polluting defaults in other models, due to `_.defaults()` parameters appearing in the wrong order. This change fixes three cases that were found, and finishes an audit of all uses in the Review Board codebase.	bcf69530ff1a87f316e269d71aeed5e6afe714db

flake8 passed.

JSHint passed.

Ship it!

Ship it!

Pushed to release-6.x (59db38f)