Add typing and clean up code in the Subversion support.

Review Request #13225 — Created Aug. 20, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

This adds typing throughout the Subversion codebase, ensuring
consistency in calls, results, and dictionary contents.

There are some fixes for some bad assumptions in the code, and some
minor changes to the base SCMTool class to make
parse_diff_revision()'s parameters consistent with the built-in
SCMTools.

Changes will build upon this to improve operation invocation and error
handling, in preparation for the new SSL management.

Unit tests pass.

Diff Revision 5

This is not the most recent revision of the diff. The latest diff is revision 6. See what's changed.

orig
1
2
3
4
5
6

Commits

First Last Summary ID Author
Add typing and clean up code in the Subversion support.
This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.
db24fd8a32b65917dc3c3b111e1a5e01c13a671d Christian Hammond
reviewboard/scmtools/core.py
reviewboard/scmtools/svn/__init__.py
reviewboard/scmtools/svn/base.py
reviewboard/scmtools/svn/pysvn.py
reviewboard/scmtools/svn/utils.py
Loading...