Add typing and clean up code in the Subversion support.

Review Request #13225 — Created Aug. 20, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This adds typing throughout the Subversion codebase, ensuring
consistency in calls, results, and dictionary contents.

There are some fixes for some bad assumptions in the code, and some
minor changes to the base SCMTool class to make
parse_diff_revision()'s parameters consistent with the built-in
SCMTools.

Changes will build upon this to improve operation invocation and error
handling, in preparation for the new SSL management.

Unit tests pass.

Summary ID
Add typing and clean up code in the Subversion support.
This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.
8eca61994cffbedb7809fd5721d3ce0eb26a0831
Description From Last Updated

redefinition of unused 'Optional' from line 9 Column: 1 Error code: F811

reviewbotreviewbot

redefinition of unused 'TYPE_CHECKING' from line 9 Column: 1 Error code: F811

reviewbotreviewbot

These are missing type info.

daviddavid

Missing type info.

daviddavid

Missing type info.

daviddavid

Missing type info.

daviddavid
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
chipx86
chipx86
chipx86
david
  1. 
      
  2. reviewboard/scmtools/svn/base.py (Diff revision 5)
     
     
     
     
     

    These are missing type info.

  3. reviewboard/scmtools/svn/base.py (Diff revision 5)
     
     

    Missing type info.

  4. reviewboard/scmtools/svn/pysvn.py (Diff revision 5)
     
     
     
     
     

    Missing type info.

  5. reviewboard/scmtools/svn/pysvn.py (Diff revision 5)
     
     

    Missing type info.

  6. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (0c1392b)
Loading...