Summary

Add typing and clean up code in the Subversion support.

Review Request #13225 — Created Aug. 20, 2023 and submitted Aug. 25, 2023, 1:58 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

~~13224~~

Blocks

13226

Reviewers

Groups

reviewboard

People

Description

This adds typing throughout the Subversion codebase, ensuring

consistency in calls, results, and dictionary contents.
There are some fixes for some bad assumptions in the code, and some

minor changes to the base SCMTool class to make

parse_diff_revision()'s parameters consistent with the built-in

SCMTools.
Changes will build upon this to improve operation invocation and error

handling, in preparation for the new SSL management.

Testing Done

Unit tests pass.

Commits

Summary	ID
Add typing and clean up code in the Subversion support. This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.	8eca61994cffbedb7809fd5721d3ce0eb26a0831

Summary

Add typing and clean up code in the Subversion support.

This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.

8eca61994cffbedb7809fd5721d3ce0eb26a0831

Issues

Description	From	Last Updated
redefinition of unused 'Optional' from line 9 Column: 1 Error code: F811	reviewbot	Aug. 20, 2023, 1:18 a.m.
redefinition of unused 'TYPE_CHECKING' from line 9 Column: 1 Error code: F811	reviewbot	Aug. 20, 2023, 1:18 a.m.
These are missing type info.	david	Aug. 24, 2023, 3:04 p.m.
Missing type info.	david	Aug. 24, 2023, 3:04 p.m.
Missing type info.	david	Aug. 24, 2023, 3:05 p.m.
Missing type info.	david	Aug. 24, 2023, 3:05 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/core.py (Diff revision 1)
The issue has been resolved. Show all issues
```
redefinition of unused 'Optional' from line 9

Column: 1
Error code: F811
```
reviewboard/scmtools/core.py (Diff revision 1)
The issue has been resolved. Show all issues
```
redefinition of unused 'TYPE_CHECKING' from line 9

Column: 1
Error code: F811
```

Change Summary:

Fixed some typing imports in reviewboard.scmtools.core.

Commits:

	Summary	ID
	Add typing and clean up code in the Subversion support. This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.	b2a7750bba3547ec7e54ec828ddcbd5b647f6a3f
	Add typing and clean up code in the Subversion support. This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.	5316c2807ce9f618f6ff7a368b006f7aaa64117e

Diff:

Revision 2 (+1006 -228)

Show changes

	reviewboard/scmtools/core.py
	reviewboard/scmtools/svn/__init__.py
	reviewboard/scmtools/svn/base.py
	reviewboard/scmtools/svn/pysvn.py
	reviewboard/scmtools/svn/utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Added missing instance variable types.

Commits:

	Summary	ID
	Add typing and clean up code in the Subversion support. This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.	5316c2807ce9f618f6ff7a368b006f7aaa64117e
	Add typing and clean up code in the Subversion support. This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.	a1a4b9214ec711122688f7484e0b93ce47ae98a3

Diff:

Revision 3 (+1034 -230)

Show changes

	reviewboard/scmtools/core.py
	reviewboard/scmtools/svn/__init__.py
	reviewboard/scmtools/svn/base.py
	reviewboard/scmtools/svn/pysvn.py
	reviewboard/scmtools/svn/utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:


Removed the unused SVNTool.config_dir, simplifying __init__ and build_client.
Switched to get_data_dir() instead of computing the home directory.
Moved the base SVN client class to use the abc module for abstract properties/methods.
Added missing typing for SVNRepositoryInfoDict and repository_info().
Added missing typing for the client: pysvn.Client.

Commits:

	Summary	ID
	Add typing and clean up code in the Subversion support. This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.	a1a4b9214ec711122688f7484e0b93ce47ae98a3
	Add typing and clean up code in the Subversion support. This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.	7542d13d3bc22978ed226bbdb32e07a5d8ce6db5

Diff:

Revision 4 (+1156 -296)

Show changes

	reviewboard/scmtools/core.py
	reviewboard/scmtools/svn/__init__.py
	reviewboard/scmtools/svn/base.py
	reviewboard/scmtools/svn/pysvn.py
	reviewboard/scmtools/svn/utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fixed a bad build_client() call.

Commits:

	Summary	ID
	Add typing and clean up code in the Subversion support. This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.	7542d13d3bc22978ed226bbdb32e07a5d8ce6db5
	Add typing and clean up code in the Subversion support. This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.	db24fd8a32b65917dc3c3b111e1a5e01c13a671d

Diff:

Revision 5 (+1158 -298)

Show changes

	reviewboard/scmtools/core.py
	reviewboard/scmtools/svn/__init__.py
	reviewboard/scmtools/svn/base.py
	reviewboard/scmtools/svn/pysvn.py
	reviewboard/scmtools/svn/utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/scmtools/svn/base.py (Diff revision 5)
The issue has been resolved. Show all issues
```
These are missing type info.
```
reviewboard/scmtools/svn/base.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Missing type info.
```
reviewboard/scmtools/svn/pysvn.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Missing type info.
```
reviewboard/scmtools/svn/pysvn.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Missing type info.
```

Change Summary:

Added missing typing information.

Commits:

	Summary	ID
	Add typing and clean up code in the Subversion support. This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.	db24fd8a32b65917dc3c3b111e1a5e01c13a671d
	Add typing and clean up code in the Subversion support. This adds typing throughout the Subversion codebase, ensuring consistency in calls, results, and dictionary contents. There are some fixes for some bad assumptions in the code, and some minor changes to the base `SCMTool` class to make `parse_diff_revision()`'s parameters consistent with the built-in SCMTools. Changes will build upon this to improve operation invocation and error handling, in preparation for the new SSL management.	8eca61994cffbedb7809fd5721d3ce0eb26a0831

Diff:

Revision 6 (+1192 -334)

Show changes

	reviewboard/scmtools/core.py
	reviewboard/scmtools/svn/__init__.py
	reviewboard/scmtools/svn/base.py
	reviewboard/scmtools/svn/pysvn.py
	reviewboard/scmtools/svn/utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (0c1392b)