Add typing and clean up code in the Subversion support.

 






 

 


  Review Request #13225
  —
  Created Aug. 20, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  13224
 









 
 

  13226
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This adds typing throughout the Subversion codebase, ensuring

consistency in calls, results, and dictionary contents.


There are some fixes for some bad assumptions in the code, and some

minor changes to the base SCMTool class to make

parse_diff_revision()'s parameters consistent with the built-in

SCMTools.


Changes will build upon this to improve operation invocation and error

handling, in preparation for the new SSL management.

 








  


 
 

  
Unit tests pass.

 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3
4
5
6

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Add typing and clean up code in the Subversion support.
     
This adds typing throughout the Subversion codebase, ensuring
consistency in calls, results, and dictionary contents.

There are some fixes for some bad assumptions in the code, and some
minor changes to the base `SCMTool` class to make
`parse_diff_revision()`'s parameters consistent with the built-in
SCMTools.

Changes will build upon this to improve operation invocation and error
handling, in preparation for the new SSL management.

    

   
  		
  5316c2807ce9f618f6ff7a368b006f7aaa64117e
  Christian Hammond
 


 
  
 
 
  
   
    

     Add typing and clean up code in the Subversion support.
     
This adds typing throughout the Subversion codebase, ensuring
consistency in calls, results, and dictionary contents.

There are some fixes for some bad assumptions in the code, and some
minor changes to the base `SCMTool` class to make
`parse_diff_revision()`'s parameters consistent with the built-in
SCMTools.

Changes will build upon this to improve operation invocation and error
handling, in preparation for the new SSL management.

    

   
  		
  a1a4b9214ec711122688f7484e0b93ce47ae98a3
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/scmtools/core.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/svn/__init__.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...