Summary

Fix a regression in extension packaging.

Review Request #13213 — Created Aug. 14, 2023 and submitted Aug. 15, 2023, 2:33 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

When typing was introduced for djblets.extensions.packaging, an import

was added that triggered Django model/app machinery. This ended up

breaking, since we weren't setting up a Django environment at this

stage.
This import was only needed for typing, so it's been moved into a

TYPE_CHECKING block.

Testing Done

Successfully installed extension packages.

Commits

Summary	ID
Fix a regression in extension packaging. When typing was introduced for `djblets.extensions.packaging`, an import was added that triggered Django model/app machinery. This ended up breaking, since we weren't setting up a Django environment at this stage. This import was only needed for typing, so it's been moved into a `TYPE_CHECKING` block.	bf3eaadab2dd358430d8730a96f6b28a671c3e4a

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.x (859430e)