Summary:

Fix the image button in the formatting toolbar.

Review Request #13211 — Created Aug. 14, 2023 and submitted Aug. 21, 2023, 4:41 p.m.

Information
Owner:	maubin
Repository:	Review Board
Branch:	release-6.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

The image button in the formatting toolbar would prompt for a file, but never
actually inserted it into the editor. This change fixes that.

Testing Done


Tested uploading images through the image button in empty and non-empty

  editors, and at various positions in the editor. Saw that this behaved in

  the same way as dragging and dropping images.
Tested using the other buttons in the editor.

Commits

Summary
Make the image button in the formatting toolbar work.

Screenshots

Issues

Description	From	Last Updated
Hold off on any reviews because I'll be updating this for the changes from /r/13212/.	maubin	Aug. 18, 2023, 10:57 a.m.
The custom _uploadImage callback on the interface is going to be too specific to this case, and it's not something …	chipx86	Aug. 20, 2023, 11:50 a.m.

flake8 passed.

JSHint passed.

Show all issues

Hold off on any reviews because I'll be updating this for the changes from /r/13212/.

Commits:

	Summary
-	Make the image button in the formatting toolbar work.
+	Make the image button in the formatting toolbar work.

Diff:

Revision 2 (+64 -2)

Show changes

reviewboard/static/rb/js/ui/views/textEditorView.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Show all issues

The custom _uploadImage callback on the interface is going to be too specific to this case, and it's not something that extensions could take advantage of.

I think an approach worth exploring is just letting this button emit an event on the view, e.g. uploadImage. TextEditorView could then listen to this event and do the right thing. If something else were to use FormattingToolbarView (theoretically), it could implement its own logic there.

Commits:

	Summary
-	Make the image button in the formatting toolbar work.
+	Make the image button in the formatting toolbar work.

Diff:

Revision 3 (+56 -2)

Show changes

reviewboard/static/rb/js/ui/views/textEditorView.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (9d080fc)