Summary

Add a bit of type info to configforms classes.

Review Request #13208 — Created Aug. 14, 2023 and submitted Aug. 21, 2023, 4:06 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This change adds some type hints for the base classes in the configforms
app (ConfigPage and ConfigPageForm). This doesn't cover very much of the
app code, but is enough for subclasses to make use of.

Testing Done

Ran unit tests.

Commits

Summary	ID
Add a bit of type info to configforms classes. This change adds some type hints for the base classes in the configforms app (ConfigPage and ConfigPageForm). This doesn't cover very much of the app code, but is enough for subclasses to make use of. Testing Done: Ran unit tests.	f676e5e32b68e941eaa7c1db664d77a9489f2de5

Issues

Description	From	Last Updated
Can you add a __future__ ... annotations import?	chipx86	Aug. 15, 2023, 10 a.m.
__future__ import?	chipx86	Aug. 15, 2023, 10 a.m.

flake8 passed.

JSHint passed.

djblets/configforms/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you add a __future__ ... annotations import?
```
djblets/configforms/pages.py (Diff revision 1)
The issue has been resolved. Show all issues
```
__future__ import?
```

Commits:

	Summary	ID
	Add a bit of type info to configforms classes. This change adds some type hints for the base classes in the configforms app (ConfigPage and ConfigPageForm). This doesn't cover very much of the app code, but is enough for subclasses to make use of. Testing Done: Ran unit tests.	cdf6acf8b88ca8cc96907bd4958eeda10bc10798
	Add a bit of type info to configforms classes. This change adds some type hints for the base classes in the configforms app (ConfigPage and ConfigPageForm). This doesn't cover very much of the app code, but is enough for subclasses to make use of. Testing Done: Ran unit tests.	f676e5e32b68e941eaa7c1db664d77a9489f2de5

Diff:

Revision 2 (+54 -22)

Show changes

	djblets/configforms/forms.py
	djblets/configforms/pages.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (53dc700)