Tweak spacing on the rich text formatting toolbar.

 






 

 


  Review Request #13204
  —
  Created Aug. 11, 2023 and discarded 

 




















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The new formatting toolbar was a little bit too high up inside the text

box, due to stacked margin/padding. This change alters the margins so

that the buttons appear with the same visual spacing on the left and

bottom.


While I was here I also deleted an unused interface that was left over

from an earlier iteration of the implementation.

 








  


 
 

  
Looked at the formatting toolbar and saw that it was positioned better.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Tweak spacing on the rich text formatting toolbar.
      
The new formatting toolbar was a little bit too high up inside the text
box, due to stacked margin/padding. This change alters the margins so
that the buttons appear with the same visual spacing on the left and
bottom.

While I was here I also deleted an unused interface that was left over
from an earlier iteration of the implementation.

Testing Done:
Looked at the formatting toolbar and saw that it was positioned better.

     


    		
    07ef8c71f9bf52fbd9212ba9df6ffc0a4ba81fe1

   



  
 




 













 

  
  


   

    

     

     

     

    

   


   

  

 







 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Does this fix the "grey bar at the bottom of some editors" problem we discussed in the meeting?

      		
      
       maubinmaubin
      
      
       
      
     




     

      
       
       
Oh thought this was on my plate. I actually have a bunch of work queued up on some stuff around …

      		
      
       chipx86chipx86
      
      
       
      
     


    
   

  

 







 






  

 



















 




 




 














 





 

  

   




maubin




   

   







  

 



 

  


   

   

    
 
maubin


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Does this fix the "grey bar at the bottom of some editors" problem we discussed in the meeting?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I don't know because I've never seen that myself.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Oops forgot about that. I'll look into it since I can repro.
      
 
      

      3. 


 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




maubin




   

   







  

 



 

  


   

   

    
 
maubin


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Oh thought this was on my plate. I actually have a bunch of work queued up on some stuff around this, which is a bit more of an involved fix.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Discarded

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...