Move pending calls for some unit tests into beforeEach.

 






 

 


  Review Request #13203
  —
  Created Aug. 11, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
There's a change between Jasmine 3.x and 4.x where exceptions inside of

beforeEach now cause the suite to fail. Our code for the old draft

banner tests are mostly disabled, but some of the setup code was hitting

this. This change moves the pending call to happen inside

beforeEach, which disables the whole suite without errors.

 








  


 
 

  
Ran js-tests.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Move pending calls for some unit tests into beforeEach.
     
There's a change between Jasmine 3.x and 4.x where exceptions inside of
beforeEach now cause the suite to fail. Our code for the old draft
banner tests are mostly disabled, but some of the setup code was hitting
this. This change moves the `pending` call to happen inside
`beforeEach`, which disables the whole suite without errors.

Testing Done:
Ran js-tests.

    

   
  		
  b5ac08fa810eca8d4d87b7d9740ef8282a1e30df
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/tests/reviewRequestEditorViewTests.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...