Summary

Move pending calls for some unit tests into beforeEach.

Review Request #13203 — Created Aug. 11, 2023 and submitted Aug. 21, 2023, 3:55 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

There's a change between Jasmine 3.x and 4.x where exceptions inside of
beforeEach now cause the suite to fail. Our code for the old draft
banner tests are mostly disabled, but some of the setup code was hitting
this. This change moves the pending call to happen inside
beforeEach, which disables the whole suite without errors.

Testing Done

Ran js-tests.

Commits

Summary	ID
Move pending calls for some unit tests into beforeEach. There's a change between Jasmine 3.x and 4.x where exceptions inside of beforeEach now cause the suite to fail. Our code for the old draft banner tests are mostly disabled, but some of the setup code was hitting this. This change moves the `pending` call to happen inside `beforeEach`, which disables the whole suite without errors. Testing Done: Ran js-tests.	b5ac08fa810eca8d4d87b7d9740ef8282a1e30df

Summary

Move pending calls for some unit tests into beforeEach.

There's a change between Jasmine 3.x and 4.x where exceptions inside of beforeEach now cause the suite to fail. Our code for the old draft banner tests are mostly disabled, but some of the setup code was hitting this. This change moves the `pending` call to happen inside `beforeEach`, which disables the whole suite without errors. Testing Done: Ran js-tests.

b5ac08fa810eca8d4d87b7d9740ef8282a1e30df

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (17ebbcc)