Bump to Jasmine 5.1 and jasmine-suites 2.0.

Review Request #13202 — Created Aug. 11, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This change bumps our jasmine dependency up to 5.1. This also required
pulling in the new version of jasmine-suites, which fixes things up to
work with the changed jasmine APIs.

Try as I might I cannot get jasmine to bundle out of node_modules via
imports. We're therefore still bundling it in js-test-libs.

Ran js-tests.

Summary ID
Bump to Jasmine 5.1 and jasmine-suites 2.0.
This change bumps our jasmine dependency up to 5.1. This also required pulling in the new version of jasmine-suites, which fixes things up to work with the changed jasmine APIs. Try as I might I cannot get jasmine to bundle out of node_modules via imports. We're therefore still bundling it in js-test-libs. Testing Done: Ran js-tests.
f65e2ca7e1e0e72f4e4b169a50ff4af02afdb961
Description From Last Updated

'extractCustomPendingMessage' was used before it was defined. Column: 9 Error code: W003

reviewbotreviewbot

'runner' was used before it was defined. Column: 9 Error code: W003

reviewbotreviewbot

Inner functions should be listed at the top of the outer function. Column: 7 Error code: W026

reviewbotreviewbot

'addExpectationResult' was used before it was defined. Column: 16 Error code: W003

reviewbotreviewbot

'routeLateFailure' was used before it was defined. Column: 14 Error code: W003

reviewbotreviewbot

'deprecator' was used before it was defined. Column: 11 Error code: W003

reviewbotreviewbot

'ensureNonParallel' was used before it was defined. Column: 14 Error code: W003

reviewbotreviewbot

'validateConfigForParallel' was used before it was defined. Column: 14 Error code: W003

reviewbotreviewbot

'specResultCallback' was used before it was defined. Column: 14 Error code: W003

reviewbotreviewbot

'specStarted' was used before it was defined. Column: 14 Error code: W003

reviewbotreviewbot

'reportSpecDone' was used before it was defined. Column: 14 Error code: W003

reviewbotreviewbot

Expected '===' and instead saw '=='. Column: 35 Error code: W116

reviewbotreviewbot

'callerCallerFilename' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

Inner functions should be listed at the top of the outer function. Column: 5 Error code: W026

reviewbotreviewbot

'message' was used before it was defined. Column: 14 Error code: W003

reviewbotreviewbot

'stack' was used before it was defined. Column: 14 Error code: W003

reviewbotreviewbot

'isDescendent' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (timeoutKey) Column: 45 Error code: W083

reviewbotreviewbot

'indexOfFirstToPass' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

'syncNegatingFilter' was used before it was defined. Column: 9 Error code: W003

reviewbotreviewbot

'asyncNegatingFilter' was used before it was defined. Column: 9 Error code: W003

reviewbotreviewbot

'expectSettledPromiseFilter' was used before it was defined. Column: 9 Error code: W003

reviewbotreviewbot

'dispatchBrowserError' was used before it was defined. Column: 14 Error code: W003

reviewbotreviewbot

Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (i, diffBuilder, actualArrayIsLongerFormatter, result, a, b, …

reviewbotreviewbot

Expected '===' and instead saw '=='. Column: 52 Error code: W116

reviewbotreviewbot

Expected '===' and instead saw '=='. Column: 42 Error code: W116

reviewbotreviewbot

Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (a, b, aStack, bStack, diffBuilder, result) …

reviewbotreviewbot

'formatKeyValuePairs' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

Expected '{' and instead saw 'continue'. Column: 31 Error code: W116

reviewbotreviewbot

Missing 'new' prefix when invoking a constructor. Column: 24 Error code: W064

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-6.x (75e5669)