Summary

Bump to Jasmine 5.1 and jasmine-suites 2.0.

Review Request #13202 — Created Aug. 11, 2023 and submitted Aug. 21, 2023, 3:55 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change bumps our jasmine dependency up to 5.1. This also required
pulling in the new version of jasmine-suites, which fixes things up to
work with the changed jasmine APIs.

Try as I might I cannot get jasmine to bundle out of node_modules via
imports. We're therefore still bundling it in js-test-libs.

Testing Done

Ran js-tests.

Commits

Summary	ID
Bump to Jasmine 5.1 and jasmine-suites 2.0. This change bumps our jasmine dependency up to 5.1. This also required pulling in the new version of jasmine-suites, which fixes things up to work with the changed jasmine APIs. Try as I might I cannot get jasmine to bundle out of node_modules via imports. We're therefore still bundling it in js-test-libs. Testing Done: Ran js-tests.	f65e2ca7e1e0e72f4e4b169a50ff4af02afdb961

Issues

Description	From	Last Updated
'extractCustomPendingMessage' was used before it was defined. Column: 9 Error code: W003	reviewbot	Aug. 11, 2023, 10 a.m.
'runner' was used before it was defined. Column: 9 Error code: W003	reviewbot	Aug. 11, 2023, 10 a.m.
Inner functions should be listed at the top of the outer function. Column: 7 Error code: W026	reviewbot	Aug. 11, 2023, 10 a.m.
'addExpectationResult' was used before it was defined. Column: 16 Error code: W003	reviewbot	Aug. 11, 2023, 10 a.m.
'routeLateFailure' was used before it was defined. Column: 14 Error code: W003	reviewbot	Aug. 11, 2023, 10 a.m.
'deprecator' was used before it was defined. Column: 11 Error code: W003	reviewbot	Aug. 11, 2023, 10 a.m.
'ensureNonParallel' was used before it was defined. Column: 14 Error code: W003	reviewbot	Aug. 11, 2023, 10 a.m.
'validateConfigForParallel' was used before it was defined. Column: 14 Error code: W003	reviewbot	Aug. 11, 2023, 10 a.m.
'specResultCallback' was used before it was defined. Column: 14 Error code: W003	reviewbot	Aug. 11, 2023, 10 a.m.
'specStarted' was used before it was defined. Column: 14 Error code: W003	reviewbot	Aug. 11, 2023, 10 a.m.
'reportSpecDone' was used before it was defined. Column: 14 Error code: W003	reviewbot	Aug. 11, 2023, 10:01 a.m.
Expected '===' and instead saw '=='. Column: 35 Error code: W116	reviewbot	Aug. 11, 2023, 10:01 a.m.
'callerCallerFilename' was used before it was defined. Column: 12 Error code: W003	reviewbot	Aug. 11, 2023, 10:01 a.m.
Inner functions should be listed at the top of the outer function. Column: 5 Error code: W026	reviewbot	Aug. 11, 2023, 10:01 a.m.
'message' was used before it was defined. Column: 14 Error code: W003	reviewbot	Aug. 11, 2023, 10:01 a.m.
'stack' was used before it was defined. Column: 14 Error code: W003	reviewbot	Aug. 11, 2023, 10:01 a.m.
'isDescendent' was used before it was defined. Column: 12 Error code: W003	reviewbot	Aug. 11, 2023, 10:01 a.m.
Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (timeoutKey) Column: 45 Error code: W083	reviewbot	Aug. 11, 2023, 10:01 a.m.
'indexOfFirstToPass' was used before it was defined. Column: 12 Error code: W003	reviewbot	Aug. 11, 2023, 10:01 a.m.
'syncNegatingFilter' was used before it was defined. Column: 9 Error code: W003	reviewbot	Aug. 11, 2023, 10:01 a.m.
'asyncNegatingFilter' was used before it was defined. Column: 9 Error code: W003	reviewbot	Aug. 11, 2023, 10:01 a.m.
'expectSettledPromiseFilter' was used before it was defined. Column: 9 Error code: W003	reviewbot	Aug. 11, 2023, 10:01 a.m.
'dispatchBrowserError' was used before it was defined. Column: 14 Error code: W003	reviewbot	Aug. 11, 2023, 10:01 a.m.
Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (i, diffBuilder, actualArrayIsLongerFormatter, result, a, b, …	reviewbot	Aug. 11, 2023, 10:01 a.m.
Expected '===' and instead saw '=='. Column: 52 Error code: W116	reviewbot	Aug. 11, 2023, 10:01 a.m.
Expected '===' and instead saw '=='. Column: 42 Error code: W116	reviewbot	Aug. 11, 2023, 10:01 a.m.
Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (a, b, aStack, bStack, diffBuilder, result) …	reviewbot	Aug. 11, 2023, 10:01 a.m.
'formatKeyValuePairs' was used before it was defined. Column: 12 Error code: W003	reviewbot	Aug. 11, 2023, 10:01 a.m.
Expected '{' and instead saw 'continue'. Column: 31 Error code: W116	reviewbot	Aug. 11, 2023, 10:01 a.m.
Missing 'new' prefix when invoking a constructor. Column: 24 Error code: W064	reviewbot	Aug. 11, 2023, 10:01 a.m.

flake8 passed.

JSHint failed.

JSHint

```
Warning: Showing 30 of 47 failures.
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'extractCustomPendingMessage' was used before it was defined.

Column: 9
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'runner' was used before it was defined.

Column: 9
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Inner functions should be listed at the top of the outer function.

Column: 7
Error code: W026
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'addExpectationResult' was used before it was defined.

Column: 16
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'routeLateFailure' was used before it was defined.

Column: 14
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'deprecator' was used before it was defined.

Column: 11
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'ensureNonParallel' was used before it was defined.

Column: 14
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'validateConfigForParallel' was used before it was defined.

Column: 14
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'specResultCallback' was used before it was defined.

Column: 14
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'specStarted' was used before it was defined.

Column: 14
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'reportSpecDone' was used before it was defined.

Column: 14
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '===' and instead saw '=='.

Column: 35
Error code: W116
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'callerCallerFilename' was used before it was defined.

Column: 12
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Inner functions should be listed at the top of the outer function.

Column: 5
Error code: W026
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'message' was used before it was defined.

Column: 14
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'stack' was used before it was defined.

Column: 14
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'isDescendent' was used before it was defined.

Column: 12
Error code: W003
```

reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)

The issue has been dropped. Show all issues

Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (timeoutKey)

Column: 45
Error code: W083

reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'indexOfFirstToPass' was used before it was defined.

Column: 12
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'syncNegatingFilter' was used before it was defined.

Column: 9
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'asyncNegatingFilter' was used before it was defined.

Column: 9
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'expectSettledPromiseFilter' was used before it was defined.

Column: 9
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'dispatchBrowserError' was used before it was defined.

Column: 14
Error code: W003
```

reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)

The issue has been dropped. Show all issues

Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (i, diffBuilder, actualArrayIsLongerFormatter, result, a, b, aStack, bStack)

Column: 33
Error code: W083

reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '===' and instead saw '=='.

Column: 52
Error code: W116
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '===' and instead saw '=='.

Column: 42
Error code: W116
```

reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)

The issue has been dropped. Show all issues

Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (a, b, aStack, bStack, diffBuilder, result)

Column: 33
Error code: W083

reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'formatKeyValuePairs' was used before it was defined.

Column: 12
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '{' and instead saw 'continue'.

Column: 31
Error code: W116
```
reviewboard/static/lib/js/js-test-libs/jasmine-5.1.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Missing 'new' prefix when invoking a constructor.

Column: 24
Error code: W064
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (75e5669)