Fix a bug with showing content of deleted files in the diff viewer.

Review Request #13196 — Created Aug. 9, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This fixes a bug with the show content link for deleted files in the diff
viewer. The link wouldn't show the content of the file and would instead
remove it from the diff viewer. This is fixed by properly replacing existing
file diffs in the diff viewer when the show content link is clicked.

  • Clicked on show content for multiple files in a diff viewer and saw that
    they were shown properly.
  • Saw that the diff file index properly listed files depending on which
    files are visible on screen, both before and after clicking show content.
  • Saw that diffs were properly rendered for non-deleted files.
  • Ran JS unit tests.
Summary ID
Fix a regression with the showing content of deleted files in the diff viewer.
bec0706efac1bcfa00f282c0569a2404f6ea9b74
Description From Last Updated

No double asterisk--this should just be /* ... */

daviddavid

Can we rewrap as: let index = this._diffReviewableViews.findIndex( view => (view.model === diffReviewable));

daviddavid
david
  1. 
      
  2. No double asterisk--this should just be /* ... */

  3. Can we rewrap as:

    let index = this._diffReviewableViews.findIndex(
        view => (view.model === diffReviewable));
    
  4. 
      
maubin
david
  1. Ship It!
  2. 
      
maubin
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (8f92897)
Loading...