flake8
passed.
JSHint
passed.
Review Request #13196 — Created Aug. 9, 2023 and submitted
Information | |
---|---|
maubin | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
This fixes a bug with the show content link for deleted files in the diff
viewer. The link wouldn't show the content of the file and would instead
remove it from the diff viewer. This is fixed by properly replacing existing
file diffs in the diff viewer when the show content link is clicked.
reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts (Diff revision 1) |
---|
No double asterisk--this should just be
/* ... */
reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts (Diff revision 1) |
---|
Can we rewrap as:
let index = this._diffReviewableViews.findIndex( view => (view.model === diffReviewable));
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+34 -6) |