flake8
passed.
JSHint
passed.
Fix a bug with showing content of deleted files in the diff viewer.
Review Request #13196 — Created Aug. 9, 2023 and submitted
This fixes a bug with the show content link for deleted files in the diff
viewer. The link wouldn't show the content of the file and would instead
remove it from the diff viewer. This is fixed by properly replacing existing
file diffs in the diff viewer when the show content link is clicked.
- Clicked on show content for multiple files in a diff viewer and saw that
they were shown properly. - Saw that the diff file index properly listed files depending on which
files are visible on screen, both before and after clicking show content. - Saw that diffs were properly rendered for non-deleted files.
- Ran JS unit tests.
-
-
reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts (Diff revision 1) No double asterisk--this should just be
/* ... */ -
reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts (Diff revision 1) Can we rewrap as:
let index = this._diffReviewableViews.findIndex( view => (view.model === diffReviewable));
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+34 -6) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.