Summary

Fix a bug with showing content of deleted files in the diff viewer.

Review Request #13196 — Created Aug. 9, 2023 and submitted Aug. 10, 2023, 5 p.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This fixes a bug with the show content link for deleted files in the diff
viewer. The link wouldn't show the content of the file and would instead
remove it from the diff viewer. This is fixed by properly replacing existing
file diffs in the diff viewer when the show content link is clicked.

Testing Done


Clicked on show content for multiple files in a diff viewer and saw that

  they were shown properly.
Saw that the diff file index properly listed files depending on which

  files are visible on screen, both before and after clicking show content.
Saw that diffs were properly rendered for non-deleted files.
Ran JS unit tests.

Commits

Summary	ID
Fix a regression with the showing content of deleted files in the diff viewer.	bec0706efac1bcfa00f282c0569a2404f6ea9b74

Issues

Description	From	Last Updated
No double asterisk--this should just be /* ... */	david	Aug. 10, 2023, 3:59 a.m.
Can we rewrap as: let index = this._diffReviewableViews.findIndex( view => (view.model === diffReviewable));	david	Aug. 10, 2023, 4:10 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
No double asterisk--this should just be /* ... */
```

reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts (Diff revision 1)

The issue has been resolved. Show all issues

Can we rewrap as:

let index = this._diffReviewableViews.findIndex(
    view => (view.model === diffReviewable));

Commits:

	Summary	ID
	Fix a regression with the showing content of deleted files in the diff viewer.	fd888de8e8efd731e70e7dec230b8afe90a2027a
	Fix a regression with the showing content of deleted files in the diff viewer.	bec0706efac1bcfa00f282c0569a2404f6ea9b74

Diff:

Revision 2 (+34 -6)

Show changes

reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (8f92897)