Update jasmine-suites to work with Jasmine 4.6.

Review Request #13189 — Created Aug. 4, 2023 and submitted — Latest diff uploaded

Information

jasmine-suites
master

Reviewers

jasmine-suites was originally written for Jasmine 1.x, and has managed
to survive up through 3.5. However, it does not work with the latest 4.6
release, due to internal changes with this no longer representing the
current suite in a call to describe().

To address this, we simply monkey-patch the SuiteBuilder, storing the
current suite being operated on. We can then reference that when needed
during building of the suites.

Along with the fix, the package is now built with Rollup and can be
deployed to npm, with CommonJS and ES module support.

Tested this previously with Jasmine 4.6 with an attempt to upgrade the
unit test dependencies for Review Board.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

orig
1
2

Commits

First Last Summary ID Author
Update jasmine-suites to work with Jasmine 4.6.
jasmine-suites was originally written for Jasmine 1.x, and has managed to survive up through 3.5. However, it does not work with the latest 4.6 release, due to internal changes with `this` no longer representing the current suite in a call to `describe()`. To address this, we simply monkey-patch the `SuiteBuilder`, storing the current suite being operated on. We can then reference that when needed during building of the suites. Along with the fix, the package is now built with Rollup and can be deployed to npm, with CommonJS and ES module support.
8acd455e7deab41a7813182df425fe8aaa118ad8 Christian Hammond
.gitignore
README.md
package.json
package-lock.json
rollup.config.js
jasmine-suites.js
Loading...