Update jasmine-suites to work with Jasmine 4.6.

Review Request #13189 — Created Aug. 4, 2023 and submitted

Information

jasmine-suites
master

Reviewers

jasmine-suites was originally written for Jasmine 1.x, and has managed
to survive up through 3.5. However, it does not work with the latest 4.6
release, due to internal changes with this no longer representing the
current suite in a call to describe().

To address this, we simply monkey-patch the SuiteBuilder, storing the
current suite being operated on. We can then reference that when needed
during building of the suites.

Along with the fix, the package is now built with Rollup and can be
deployed to npm, with CommonJS and ES module support.

Tested this previously with Jasmine 4.6 with an attempt to upgrade the
unit test dependencies for Review Board.

Summary ID
Update jasmine-suites to work with Jasmine 4.6.
jasmine-suites was originally written for Jasmine 1.x, and has managed to survive up through 3.5. However, it does not work with the latest 4.6 release, due to internal changes with `this` no longer representing the current suite in a call to `describe()`. To address this, we simply monkey-patch the `SuiteBuilder`, storing the current suite being operated on. We can then reference that when needed during building of the suites. Along with the fix, the package is now built with Rollup and can be deployed to npm, with CommonJS and ES module support.
3118f73e2803928d8f4bea61845cbb5dd0e2ec70
Description From Last Updated

We should update this while we're here.

daviddavid
david
  1. 
      
  2. src/index.js (Diff revision 1)
     
     
    Show all issues

    We should update this while we're here.

  3. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...